From: Chris Mason <chris.mason@oracle.com>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: Andrew Morton <akpm@osdl.org>,
Josef Sipek <jsipek@fsl.cs.sunysb.edu>,
linux-kernel@vger.kernel.org, hch@infradead.org,
mhalcrow@us.ibm.com, penberg@cs.helsinki.fi,
linux-fsdevel@vger.kernel.org
Subject: Re: fsstack: struct path
Date: Wed, 18 Oct 2006 10:38:10 -0400 [thread overview]
Message-ID: <20061018143810.GB16570@think.oraclecorp.com> (raw)
In-Reply-To: <20061018083527.GJ29920@ftp.linux.org.uk>
On Wed, Oct 18, 2006 at 09:35:27AM +0100, Al Viro wrote:
> On Wed, Oct 18, 2006 at 01:31:03AM -0700, Andrew Morton wrote:
> > > One, rather unfortunate, fact is that struct path is also defined in
> > > include/linux/reiserfs_fs.h as something completely different - reiserfs
> > > specific.
> > >
> > > Any thoughts?
> > >
> >
> > reiserfs is being bad. s/path/reiserfs_path/g
>
> Indeed. That's one pending patch that never got around to be submitted
> (and had bitrotten at least 3 times, IIRC).
>
> ACK, provided that reiserfs folks are OK with the replacement name for
> their struct. Note that "path" in question has very little to do with
> pathnames - it's a path in balanced tree, IIRC. So if we get around
> to renaming that sucker, it might be a good time to pick better name.
Aside from having to reindent the reiserfs tree afterwards, I doubt
anyone would mind (please cc reiserfs-dev on the patch though). Al is
right, it's a path in the balanced tree.
-chris
next prev parent reply other threads:[~2006-10-18 14:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-18 4:23 Josef Sipek
2006-10-18 8:31 ` Andrew Morton
2006-10-18 8:35 ` Al Viro
2006-10-18 14:38 ` Chris Mason [this message]
2006-10-18 8:35 ` Andrew Morton
2006-10-18 9:06 ` Al Viro
2006-10-18 9:12 ` Andrew Morton
2006-10-18 9:22 ` Al Viro
2006-10-18 9:27 ` Paul Jackson
2006-10-18 9:34 ` Al Viro
2006-10-18 10:56 ` Jörn Engel
2006-10-18 14:39 ` Erez Zadok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061018143810.GB16570@think.oraclecorp.com \
--to=chris.mason@oracle.com \
--cc=akpm@osdl.org \
--cc=hch@infradead.org \
--cc=jsipek@fsl.cs.sunysb.edu \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhalcrow@us.ibm.com \
--cc=penberg@cs.helsinki.fi \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®