From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Nicolas DET <nd@bplan-gmbh.de>,
linuxppc-dev@ozlabs.org, Olaf Hering <olaf@aepfle.de>,
linux-kernel@vger.kernel.org
Subject: Re: Badness in irq_create_mapping at arch/powerpc/kernel/irq.c:527
Date: Fri, 20 Oct 2006 11:47:49 +1000 [thread overview]
Message-ID: <20061020114749.fe7b71d6.sfr@canb.auug.org.au> (raw)
In-Reply-To: <1161308221.10524.92.camel@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 1010 bytes --]
Hi Ben,
On Fri, 20 Oct 2006 11:37:01 +1000 Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
>
> Index: linux-cell/arch/powerpc/sysdev/i8259.c
> ===================================================================
> --- linux-cell.orig/arch/powerpc/sysdev/i8259.c 2006-10-09 12:03:33.000000000 +1000
> +++ linux-cell/arch/powerpc/sysdev/i8259.c 2006-10-20 11:32:07.000000000 +1000
> @@ -13,6 +13,7 @@
> #include <linux/interrupt.h>
> #include <linux/kernel.h>
> #include <linux/delay.h>
> +#include <linux/module.h>
> #include <asm/io.h>
> #include <asm/i8259.h>
> #include <asm/prom.h>
> @@ -224,6 +225,12 @@ static struct irq_host_ops i8259_host_op
> .xlate = i8259_host_xlate,
> };
>
> +struct irq_host *i8259_get_host(void)
> +{
> + return i8259_host;
> +}
> +EXPORT_SYMBOL(i8259_get_host);
Surely it doesn't need exporting is its only caller is in
arch/powerpc/platforms/chrp/setup.c?
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2006-10-20 1:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-19 12:28 Olaf Hering
2006-10-19 13:34 ` Nicolas DET
2006-10-19 23:33 ` Benjamin Herrenschmidt
2006-10-20 1:37 ` Benjamin Herrenschmidt
2006-10-20 1:47 ` Stephen Rothwell [this message]
2006-10-20 3:24 ` Benjamin Herrenschmidt
2006-10-20 5:02 ` Sven Luther
2006-10-20 6:19 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061020114749.fe7b71d6.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=nd@bplan-gmbh.de \
--cc=olaf@aepfle.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®