mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: patches@x86-64.org, linux-kernel@vger.kernel.org
Subject: [PATCH] [19/19] x86_64: Revert timer routing behaviour back to 2.6.16 state
Date: Sat, 21 Oct 2006 18:51:39 +0200 (CEST)	[thread overview]
Message-ID: <20061021165139.C60A713CB4@wotan.suse.de> (raw)
In-Reply-To: <20061021 651.356252000@suse.de>


By default route the 8254 over the 8259 and only disable
it on ATI boards where this causes double timer interrupts.

This should unbreak some Nvidia boards where the timer doesn't
seem to tick of it isn't enabled in the 8259. At least one
VIA board also seemed to have a little trouble with the disabled
8259.

For 2.6.20 we'll try both dynamically without black listing, but I think 
for .19 this is the safer approach because it has been already well tested 
in earlier kernels. This also makes the x86-64 behaviour the same
as i386.

Command line options can change all this of course.

Signed-off-by: Andi Kleen <ak@suse.de>

---
 arch/x86_64/kernel/early-quirks.c |    9 +++++----
 arch/x86_64/kernel/io_apic.c      |    2 +-
 include/asm-x86_64/proto.h        |    2 ++
 3 files changed, 8 insertions(+), 5 deletions(-)

Index: linux/arch/x86_64/kernel/early-quirks.c
===================================================================
--- linux.orig/arch/x86_64/kernel/early-quirks.c
+++ linux/arch/x86_64/kernel/early-quirks.c
@@ -61,10 +61,11 @@ static void nvidia_bugs(void)
 
 static void ati_bugs(void)
 {
-#if 1 /* for testing */
-	printk("ATI board detected\n");
-#endif
-	/* No bugs right now */
+	if (timer_over_8254 == 1) {
+		timer_over_8254 = 0;
+		printk(KERN_INFO
+	 	"ATI board detected. Disabling timer routing over 8254.\n");
+	}
 }
 
 struct chipset {
Index: linux/arch/x86_64/kernel/io_apic.c
===================================================================
--- linux.orig/arch/x86_64/kernel/io_apic.c
+++ linux/arch/x86_64/kernel/io_apic.c
@@ -57,7 +57,7 @@ static int no_timer_check;
 
 static int disable_timer_pin_1 __initdata;
 
-int timer_over_8254 __initdata = 0;
+int timer_over_8254 __initdata = 1;
 
 /* Where if anywhere is the i8259 connect in external int mode */
 static struct { int pin, apic; } ioapic_i8259 = { -1, -1 };
Index: linux/include/asm-x86_64/proto.h
===================================================================
--- linux.orig/include/asm-x86_64/proto.h
+++ linux/include/asm-x86_64/proto.h
@@ -122,6 +122,8 @@ extern int fix_aperture;
 extern int reboot_force;
 extern int notsc_setup(char *);
 
+extern int timer_over_8254;
+
 extern int gsi_irq_sharing(int gsi);
 
 extern void smp_local_timer_interrupt(void);

      parent reply	other threads:[~2006-10-21 16:54 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20061021 651.356252000@suse.de>
2006-10-21 16:51 ` [PATCH] [1/19] x86_64: Update defconfig Andi Kleen
2006-10-21 16:51 ` [PATCH] [2/19] i386: " Andi Kleen
2006-10-21 16:51 ` [PATCH] [3/19] x86_64: x86_64 hot-add memory srat.c fix Andi Kleen
2006-10-21 16:51 ` [PATCH] [4/19] x86_64: typo in __assign_irq_vector when updating pos for vector and offset Andi Kleen
2006-10-21 16:51 ` [PATCH] [5/19] i386: fix .cfi_signal_frame copy-n-paste error Andi Kleen
2006-10-21 16:51 ` [PATCH] [6/19] x86_64: Fix for arch/x86_64/pci/Makefile CFLAGS Andi Kleen
2006-10-21 16:51 ` [PATCH] [7/19] x86_64: fix page align in e820 allocator Andi Kleen
2006-10-21 16:51 ` [PATCH] [8/19] x86: Use -maccumulate-outgoing-args Andi Kleen
2006-10-21 17:18   ` Dave Jones
2006-10-21 18:20     ` Andi Kleen
2006-10-21 16:51 ` [PATCH] [9/19] x86_64: Speed up dwarf2 unwinder Andi Kleen
2006-10-21 16:51 ` [PATCH] [10/19] x86_64: x86_64 add NX mask for PTE entry Andi Kleen
2006-10-21 16:51 ` [PATCH] [11/19] i386: Fix fake return address Andi Kleen
2006-10-21 18:12   ` Jeremy Fitzhardinge
2006-10-21 18:14     ` Andi Kleen
2006-10-21 18:17   ` Andreas Schwab
2006-10-21 16:51 ` [PATCH] [12/19] x86_64: Fix ENOSYS in system call tracing Andi Kleen
2006-10-21 16:51 ` [PATCH] [13/19] x86_64: Revert interrupt backlink changes Andi Kleen
2006-10-21 16:51 ` [PATCH] [14/19] i386: Disable nmi watchdog on all ThinkPads Andi Kleen
2006-10-21 17:24   ` Dave Jones
2006-10-21 18:11     ` [patches] " Andi Kleen
2006-10-21 18:14       ` Dave Jones
2006-10-21 18:22         ` Andi Kleen
2006-10-21 16:51 ` [PATCH] [16/19] x86: Revert new unwind kernel stack termination Andi Kleen
2006-10-21 16:51 ` [PATCH] [18/19] x86_64: Overlapping program headers in physical addr space fix Andi Kleen
2006-10-23  7:20   ` [patches] " Jan Beulich
2006-10-23 14:41     ` Vivek Goyal
2006-10-23 15:02       ` Ian Campbell
2006-10-23 16:08       ` Jan Beulich
2006-10-21 16:51 ` Andi Kleen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061021165139.C60A713CB4@wotan.suse.de \
    --to=ak@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@x86-64.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®