mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Amit Choudhary <amit2030@yahoo.com>
To: linux-kernel@vger.kernel.org
Subject: Hopefully, kmalloc() will always succeed, but if it doesn't then....
Date: Sun, 22 Oct 2006 12:58:08 -0700 (PDT)	[thread overview]
Message-ID: <20061022195809.30126.qmail@web55607.mail.re4.yahoo.com> (raw)


Hi All,

Hopefully, kmalloc() should always succeed. But if it doesn't then the kernel is going to crash
left and right. But I guess that there's no point in running if there is no memory. Anyways, here
is what I found at many places:

func()
{
   char *a; 
   char *b;

   a = kmalloc(10, GFP_KERNEL);
   if (!a)
       goto error;

   b = kmalloc(10, GFP_KERNEL);
   if (!b)
       goto error;

 error:
  kfree(a);
  kfree(b);

}

So, if memory allocation to 'a' fails, it is going to kfree 'b'. But since 'b' is not initialized,
 kfree may crash (unless DEBUG is defined).

I have seen the same case at many places when allocating in a loop.

Regards,
Amit 


__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 

             reply	other threads:[~2006-10-22 19:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-22 19:58 Amit Choudhary [this message]
2006-10-22 20:22 ` Pekka Enberg
2006-10-22 21:09   ` Jan Engelhardt
2006-10-22 23:09     ` Amit Choudhary
2006-10-23  0:25       ` Roland Dreier
2006-10-23  4:00         ` Amit Choudhary
2006-10-22 22:51   ` Amit Choudhary

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061022195809.30126.qmail@web55607.mail.re4.yahoo.com \
    --to=amit2030@yahoo.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®