From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Andrew Morton <akpm@osdl.org>
Cc: Nigel Cunningham <ncunningham@linuxmail.org>,
LKML <linux-kernel@vger.kernel.org>, Pavel Machek <pavel@ucw.cz>
Subject: Re: Freezer.h updated patch.
Date: Sun, 22 Oct 2006 22:27:45 +0200 [thread overview]
Message-ID: <200610222227.45973.rjw@sisk.pl> (raw)
In-Reply-To: <20061022113928.11bdd17f.akpm@osdl.org>
On Sunday, 22 October 2006 20:39, Andrew Morton wrote:
> On Sun, 22 Oct 2006 14:29:33 +0200
> "Rafael J. Wysocki" <rjw@sisk.pl> wrote:
>
> > Hi,
> >
> > On Sunday, 22 October 2006 14:14, Nigel Cunningham wrote:
> > > Hi guys.
> > >
> > > I missed a couple of "#include <freezer.h>"s in yesterdays patch;
> > > funnily enough the ones in kernel/power! Here's an updated version.
> > >
> > > Rafael, did you still think the freezer.h contents should go into
> > > suspend.h?
> >
> > Yes.
> >
>
> I think freezer.h is OK. One 84-line file which does one thing is nice.
> There's little advantage to putting this code into suspend.h along with a
> bunch of somewhat-unrelated stuff.
All of this stuff has one thing in common: it is only used for suspend
(to disk or to RAM) now.
> And it expresses the point that the freezer could be used for things other
> than suspend.
Okay, then. Let's take the patch as is.
--
You never change things by fighting the existing reality.
R. Buckminster Fuller
next prev parent reply other threads:[~2006-10-22 20:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-22 12:14 Nigel Cunningham
2006-10-22 12:29 ` Rafael J. Wysocki
2006-10-22 18:39 ` Andrew Morton
2006-10-22 20:27 ` Rafael J. Wysocki [this message]
2006-10-22 21:08 ` Nigel Cunningham
2007-01-01 13:57 ` Olaf Hering
2007-01-01 22:38 ` [PATCH] Fix freezer.h mistake Nigel Cunningham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200610222227.45973.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ncunningham@linuxmail.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome