mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: torvalds@osdl.org
Cc: ctpm@ist.utl.pt, linux-kernel@vger.kernel.org
Subject: Re: Unintended commit?
Date: Mon, 23 Oct 2006 14:10:40 -0700 (PDT)	[thread overview]
Message-ID: <20061023.141040.59654407.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0610231013340.3962@g5.osdl.org>

From: Linus Torvalds <torvalds@osdl.org>
Date: Mon, 23 Oct 2006 10:13:52 -0700 (PDT)

> Indeed. Thanks for noticing.
> 
> David, can you pls explain?

Totally my mistake.

A PCI change a few days ago blows up Sparc64 so I kept putting in that
drivers/pci/quirks.c workaround in order for me to be able to test the
current tree.

I accidently commited it, again sorry.  Greg KH has a patch coming to
you soon which will move that VGA code back into x86/x86_64/IA64
specific areas and will fix the sparc64 problem properly.

I should make some modifications to my workflow so that I don't do
this again when I need to make local unrelated changes in order to
test the current tree.

When I'm grinding out a patch actively in my tree I go "git diff >diff"
and then I use a script called "mkcf" which runs diffstat on the
diff and gives me a file list, it's ugly, but here it is:

#!/bin/sh
diffstat -p 1 $* | grep -v changed | awk ' { print $1 } '

So I end up going:

1) edit files
2) git diff >diff
3) read diff
4) git commit $(mkcf diff)

Usually step #3 catches local changes I'm not intending to commit
and I just edit those out, and therefore they never end up being
committed.

Perhaps it would be cool if you could tell GIT "Look, I know I have
a change to foo.c, but it's a local hack and please act like it's
not there unless I try to do an operation where ignoring that change
is impossible, such as a merge."

The idea is that things like "git diff", "git update-index" etc.
would not show the change, but things like a "git pull" that would
reference the file with such changes would conflict.

  reply	other threads:[~2006-10-23 21:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-23 17:09 Claudio Martins
2006-10-23 17:13 ` Linus Torvalds
2006-10-23 21:10   ` David Miller [this message]
2006-10-23 21:27     ` Linus Torvalds
2006-10-24  8:40     ` Pavel Machek
2006-10-24 12:04     ` Jan Engelhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061023.141040.59654407.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=ctpm@ist.utl.pt \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®