From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+willy=40w.ods.org-S964988AbWJWSRr@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S964988AbWJWSRr (ORCPT <rfc822;willy@w.ods.org>);
	Mon, 23 Oct 2006 14:17:47 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965001AbWJWSRr
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Mon, 23 Oct 2006 14:17:47 -0400
Received: from ra.tuxdriver.com ([70.61.120.52]:43274 "EHLO ra.tuxdriver.com")
	by vger.kernel.org with ESMTP id S964988AbWJWSRr (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 23 Oct 2006 14:17:47 -0400
Date: Mon, 23 Oct 2006 14:13:29 -0400
From: Neil Horman <nhorman@tuxdriver.com>
To: Dan Carpenter <error27@gmail.com>
Cc: kernel-janitors@lists.osdl.org, akpm@osdl.org, maxk@qualcomm.com,
       benh@kernel.crashing.org, linux-kernel@vger.kernel.org,
       kjhall@us.ibm.com
Subject: Re: [KJ] [PATCH] Correct misc_register return code handling in several drivers
Message-ID: <20061023181329.GC23714@hmsreliant.homelinux.net>
References: <20061023171910.GA23714@hmsreliant.homelinux.net> <a63d67fe0610231101v2f407e7dv46adaf8dbb0fb4e@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <a63d67fe0610231101v2f407e7dv46adaf8dbb0fb4e@mail.gmail.com>
User-Agent: Mutt/1.4.1i
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Oct 23, 2006 at 11:01:36AM -0700, Dan Carpenter wrote:
> On 10/23/06, Neil Horman <nhorman@tuxdriver.com> wrote:
> >+out3:
> >+       for_each_online_node(node) {
> >+               if(timers[node] != NULL)
> >+                       kfree(timers[node]);
> >+       }
> 
> Tharindu is going to be unhappy out if he sees that.  There is a
> possibility that timers[node] is uninitialized.  if node[0] is null
> then node[1] is uninitialized and it's going to cause a crash.
> 
> regards,
> dan carpenter


Theres a memset to ensure that all the timer pointers are initalized to NULL in
the patch:

@@ -709,16 +710,18 @@ static int __init mmtimer_init(void)
        if (timers == NULL) {
                printk(KERN_ERR "%s: failed to allocate memory for device\n",
                                MMTIMER_NAME);
-               return -1;
+               goto out2;
        }

+       memset(timers,0,(sizeof(mmtimer_t *)*maxn));
+


-- 
/***************************************************
 *Neil Horman
 *Software Engineer
 *gpg keyid: 1024D / 0x92A74FA1 - http://pgp.mit.edu
 ***************************************************/