From: Yasunori Goto <y-goto@jp.fujitsu.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Dave Hansen <haveblue@us.ibm.com>,
Linux Kernel ML <linux-kernel@vger.kernel.org>,
Linux Hotplug Memory Support <lhms-devel@lists.sourceforge.net>
Subject: [Patch](memory hotplug) __GFP_NOWARN is better for __kmalloc_section_memmap()
Date: Mon, 23 Oct 2006 19:39:33 +0900 [thread overview]
Message-ID: <20061023192830.DDB2.Y-GOTO@jp.fujitsu.com> (raw)
Hello.
This patch adds __GFP_NOWARN flag to calling of __alloc_pages()
in __kmalloc_section_memmap(). It can reduce noisy failure message.
In ia64, section size is 1 GB, this means that order 8 pages are necessary
for each section's memmap. It is often very hard requirement under
heavy memory pressure as you know. So, __alloc_pages() gives up allocation
and shows many noisy stack traces which means no page for each sections.
(Current my environment shows 32 times of stack trace....)
But, __kmalloc_section_memmap() calls vmalloc() after failure of
it, and it can succeed allocation of memmap. So, its stack trace
warning becomes just noisy. I suppose it shouldn't be shown.
This patch is for 2.6.19-rc2. And I tested this patch on PrimeQuest
with high memory pressure environment.
Please apply.
Signed-off-by: Yasunori Goto <y-goto@jp.fujitsu.com>
---
mm/sparse.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
---
Index: disable_fail_message/mm/sparse.c
===================================================================
--- disable_fail_message.orig/mm/sparse.c 2006-10-17 15:05:26.000000000 +0900
+++ disable_fail_message/mm/sparse.c 2006-10-23 17:11:26.000000000 +0900
@@ -211,7 +211,7 @@ static struct page *__kmalloc_section_me
struct page *page, *ret;
unsigned long memmap_size = sizeof(struct page) * nr_pages;
- page = alloc_pages(GFP_KERNEL, get_order(memmap_size));
+ page = alloc_pages(GFP_KERNEL|__GFP_NOWARN, get_order(memmap_size));
if (page)
goto got_map_page;
--
Yasunori Goto
reply other threads:[~2006-10-23 10:40 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061023192830.DDB2.Y-GOTO@jp.fujitsu.com \
--to=y-goto@jp.fujitsu.com \
--cc=akpm@osdl.org \
--cc=haveblue@us.ibm.com \
--cc=lhms-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®