From: Muli Ben-Yehuda <muli@il.ibm.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
Yinghai Lu <yinghai.lu@amd.com>, Andi Kleen <ak@muc.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] x86_64 irq: reuse vector for set_xxx_irq_affinity in phys flat mode
Date: Mon, 23 Oct 2006 23:29:46 +0200 [thread overview]
Message-ID: <20061023212946.GA4354@rhun.haifa.ibm.com> (raw)
In-Reply-To: <20061023204519.GJ3502@stusta.de>
On Mon, Oct 23, 2006 at 10:45:19PM +0200, Adrian Bunk wrote:
> On Mon, Oct 23, 2006 at 09:32:57AM -0600, Eric W. Biederman wrote:
> > "Yinghai Lu" <yinghai.lu@amd.com> writes:
> >
> > > in phys flat mode, when using set_xxx_irq_affinity to irq balance from
> > > one cpu to another, _assign_irq_vector will get to increase last used
> > > vector and get new vector. this will use up the vector if enough
> > > set_xxx_irq_affintiy are called. and end with using same vector in
> > > different cpu for different irq. (that is not what we want, we only
> > > want to use same vector in different cpu for different irq when more
> > > than 0x240 irq needed). To keep it simple, the vector should be resued
> > > from one cpu to another instead of getting new vector.
> > >
> > > Signed-off-by: Yinghai Lu <yinghai.lu@amd.com>
> >
> > YH. I think the concept is sound. I don't think this is a bug fix, just
> > an optimization so this may not be 2.6.19 material. But we are thrashing
> > things so much it may make sense to include it, and it likely to keeps
> > us from running into problems, so it can be called a bug preventative :)
> >...
>
> Is this patch intended as fix for the 2.6.19-rc regression described
> in [1]?
No, that regression is fixed by the two x86-64 patches Eric sent in
http://marc.theaimsgroup.com/?t=116157840300001&r=1&w=2.
Cheers,
Muli
next prev parent reply other threads:[~2006-10-23 21:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-23 7:02 Yinghai Lu
2006-10-23 8:15 ` Muli Ben-Yehuda
2006-10-23 15:53 ` yhlu
2006-10-23 15:32 ` Eric W. Biederman
2006-10-23 20:45 ` Adrian Bunk
2006-10-23 21:29 ` Muli Ben-Yehuda [this message]
2006-10-23 17:34 ` Muli Ben-Yehuda
2006-10-23 20:00 Lu, Yinghai
2006-10-24 5:52 ` Oleg Verych
2006-10-24 6:03 ` yhlu
2006-10-23 21:07 Lu, Yinghai
2006-10-23 22:57 Lu, Yinghai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061023212946.GA4354@rhun.haifa.ibm.com \
--to=muli@il.ibm.com \
--cc=ak@muc.de \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yinghai.lu@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome