mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: linux-kernel@vger.kernel.org
Subject: Re: ext3 oops on shutdown
Date: Wed, 25 Oct 2006 23:06:52 -0700 (PDT)	[thread overview]
Message-ID: <20061025.230652.71090033.davem@davemloft.net> (raw)
In-Reply-To: <20061025.005134.74748405.davem@davemloft.net>

From: David Miller <davem@davemloft.net>
Date: Wed, 25 Oct 2006 00:51:34 -0700 (PDT)

> It's probably some sparc64 issue, maybe even some error wrt.  freeing
> up init memory.  I'll try to track it down.  I'm actually quite
> curious what this bug is :-)

Yep, a sparc64 bug, I'll push this to Linus shortly...

commit 2506be0657c7bd1befdb616fb0e86d87c6a288cd
Author: David S. Miller <davem@sunset.davemloft.net>
Date:   Wed Oct 25 22:33:07 2006 -0700

    [SPARC64]: Fix memory corruption in pci_4u_free_consistent().
    
    The second argument to free_npages() was being incorrectly
    calculated, which would thus access far past the end of the
    arena->map[] bitmap.
    
    Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/arch/sparc64/kernel/pci_iommu.c b/arch/sparc64/kernel/pci_iommu.c
index 82e5455..2e7f142 100644
--- a/arch/sparc64/kernel/pci_iommu.c
+++ b/arch/sparc64/kernel/pci_iommu.c
@@ -281,7 +281,7 @@ static void pci_4u_free_consistent(struc
 
 	spin_lock_irqsave(&iommu->lock, flags);
 
-	free_npages(iommu, dvma, npages);
+	free_npages(iommu, dvma - iommu->page_table_map_base, npages);
 
 	spin_unlock_irqrestore(&iommu->lock, flags);
 

      reply	other threads:[~2006-10-26  6:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-25  0:57 David Miller
2006-10-25  7:51 ` David Miller
2006-10-26  6:06   ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061025.230652.71090033.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome