From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423180AbWJYKEQ (ORCPT ); Wed, 25 Oct 2006 06:04:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1423182AbWJYKEQ (ORCPT ); Wed, 25 Oct 2006 06:04:16 -0400 Received: from gprs189-60.eurotel.cz ([160.218.189.60]:32492 "EHLO amd.ucw.cz") by vger.kernel.org with ESMTP id S1423180AbWJYKEP (ORCPT ); Wed, 25 Oct 2006 06:04:15 -0400 Date: Wed, 25 Oct 2006 12:04:05 +0200 From: Pavel Machek To: Ingo Molnar Cc: Jeremy Fitzhardinge , Andrew Morton , Linux Kernel Mailing List Subject: Re: [PATCH] Fix generic WARN_ON message Message-ID: <20061025100405.GB7658@elf.ucw.cz> References: <4535902E.1000608@goop.org> <20061018055542.GA14784@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20061018055542.GA14784@elte.hu> X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.11+cvs20060126 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hi! > * Jeremy Fitzhardinge wrote: > > > A warning is a warning, not a BUG. > > > - printk("BUG: warning at %s:%d/%s()\n", __FILE__, \ > > + printk("WARNING at %s:%d %s()\n", __FILE__, \ > > i'm not really happy about this change. > > Firstly, most WARN_ON()s are /bugs/, not warnings ... If it's a real > warning, a KERN_INFO printk should be done. > > Secondly, the reason i changed it to the 'BUG: ...' format is that i > tried to make it easier for automated tools (and for users) to figure > out that a kernel bug happened. Well... but the message is really bad. It leads to users telling us "I hit BUG in kernel"... Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html