mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Harald Welte <laforge@gnumonks.org>
To: Dominik Brodowski <linux@dominikbrodowski.net>,
	Akinobu Mita <akinobu.mita@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cm4000_cs: fix return value check
Date: Thu, 26 Oct 2006 12:25:30 +0200	[thread overview]
Message-ID: <20061026102530.GM6264@sunbeam.de.gnumonks.org> (raw)
In-Reply-To: <20061026024004.GF32048@dominikbrodowski.de>

[-- Attachment #1: Type: text/plain, Size: 911 bytes --]

On Wed, Oct 25, 2006 at 10:40:04PM -0400, Dominik Brodowski wrote:

> On Tue, Oct 17, 2006 at 03:25:59PM +0900, Akinobu Mita wrote:
> > The return value of class_create() need to be checked with IS_ERR().
> > And register_chrdev() returns errno on failure.
> > This patch includes these fixes for cm4000_cs and cm4040_cs.
> > 
> > Cc: Harald Welte <laforge@gnumonks.org>
> > Signed-off-by: Akinbou Mita <akinobu.mita@gmail.com>
> 
> Temporarily applied to pcmica-2.6.git, thanks. Harald, do you ACK?

yes, sorry.  I've been too busy and the mail slipped through...

The patch is obviously fine. Thanks!

Signed-off-by: Harald Welte <laforge@gnumonks.org>

-- 
- Harald Welte <laforge@gnumonks.org>          	        http://gnumonks.org/
============================================================================
We all know Linux is great...it does infinite loops in 5 seconds. -- Linus

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

      reply	other threads:[~2006-10-26 10:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-17  6:25 Akinobu Mita
2006-10-26  2:40 ` Dominik Brodowski
2006-10-26 10:25   ` Harald Welte [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061026102530.GM6264@sunbeam.de.gnumonks.org \
    --to=laforge@gnumonks.org \
    --cc=akinobu.mita@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@dominikbrodowski.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®