From: Andrew Morton <akpm@osdl.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Arjan van de Ven <arjan@infradead.org>,
linux-kernel@vger.kernel.org, proski@gnu.org,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
cate@debian.org, gianluca@abinetworks.biz
Subject: Re: [PATCH ??] Re: incorrect taint of ndiswrapper
Date: Fri, 27 Oct 2006 11:26:01 -0700 [thread overview]
Message-ID: <20061027112601.dbd83c32.akpm@osdl.org> (raw)
In-Reply-To: <20061027082741.8476024a.randy.dunlap@oracle.com>
On Fri, 27 Oct 2006 08:27:41 -0700
Randy Dunlap <randy.dunlap@oracle.com> wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> For ndiswrapper, don't set the module->taints flags,
> just set the kernel global tainted flag.
> This should allow ndiswrapper to continue to use GPL symbols.
> Not tested.
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
> kernel/module.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-2619-rc3-pv.orig/kernel/module.c
> +++ linux-2619-rc3-pv/kernel/module.c
> @@ -1718,7 +1718,7 @@ static struct module *load_module(void _
> set_license(mod, get_modinfo(sechdrs, infoindex, "license"));
>
> if (strcmp(mod->name, "ndiswrapper") == 0)
> - add_taint_module(mod, TAINT_PROPRIETARY_MODULE);
> + add_taint(TAINT_PROPRIETARY_MODULE);
> if (strcmp(mod->name, "driverloader") == 0)
> add_taint_module(mod, TAINT_PROPRIETARY_MODULE);
>
Could someone please test this for us?
next prev parent reply other threads:[~2006-10-27 18:26 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-25 20:11 Pavel Roskin
2006-10-25 20:30 ` Alan Cox
2006-10-25 20:40 ` Kyle Moffett
2006-10-25 21:04 ` Alan Cox
2006-10-25 21:06 ` Pavel Roskin
2006-10-25 21:33 ` David Weinehall
2006-10-25 22:02 ` Pavel Roskin
2006-10-25 22:54 ` Alan Cox
2006-10-25 22:58 ` Alan Cox
2006-10-26 3:23 ` David Weinehall
2006-10-26 13:13 ` Thierry Vignaud
2006-10-26 13:21 ` Gianluca Alberici
2006-10-26 3:59 ` Andrew Morton
2006-10-26 9:03 ` Gianluca Alberici
2006-10-26 10:39 ` Alan Cox
2006-10-26 12:21 ` Giacomo A. Catenazzi
2006-10-26 12:59 ` Gianluca Alberici
2006-10-26 14:41 ` Al Viro
2006-10-26 14:55 ` Alan Cox
2006-10-26 16:00 ` Stephen Hemminger
2006-10-26 16:26 ` Gianluca Alberici
2006-10-27 14:24 ` Arjan van de Ven
2006-10-27 15:14 ` Stephen Hemminger
2006-10-26 19:19 ` Pavel Roskin
2006-10-26 21:46 ` Adrian Bunk
2006-10-26 22:29 ` Pavel Roskin
2006-10-26 23:00 ` Adrian Bunk
2006-10-26 23:36 ` Sven-Haegar Koch
2006-10-27 0:57 ` Adrian Bunk
2006-10-26 23:47 ` Pavel Roskin
2006-10-27 12:52 ` Roland Kuhn
2006-10-27 15:53 ` Pavel Roskin
2006-10-26 17:26 ` [PATCH ??] " Randy Dunlap
2006-10-27 14:23 ` Arjan van de Ven
2006-10-27 15:27 ` Randy Dunlap
2006-10-27 18:26 ` Andrew Morton [this message]
2006-10-27 22:56 ` Florin Malita
2006-10-27 22:56 ` Randy Dunlap
2006-10-27 23:05 ` Alan Cox
2006-10-27 23:02 ` Randy Dunlap
2006-10-27 23:12 ` Florin Malita
2006-10-27 23:23 ` Oleg Verych
2006-10-29 11:27 ` Gianluca Alberici
2006-10-27 21:32 ` Florin Malita
2006-10-27 4:32 ` Florin Malita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061027112601.dbd83c32.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=arjan@infradead.org \
--cc=cate@debian.org \
--cc=gianluca@abinetworks.biz \
--cc=linux-kernel@vger.kernel.org \
--cc=proski@gnu.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome