From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946428AbWJ0Lgk (ORCPT ); Fri, 27 Oct 2006 07:36:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1946435AbWJ0Lgj (ORCPT ); Fri, 27 Oct 2006 07:36:39 -0400 Received: from mtagate3.de.ibm.com ([195.212.29.152]:36142 "EHLO mtagate3.de.ibm.com") by vger.kernel.org with ESMTP id S1946428AbWJ0LgT (ORCPT ); Fri, 27 Oct 2006 07:36:19 -0400 Date: Fri, 27 Oct 2006 13:36:54 +0200 From: Cornelia Huck To: Greg K-H Cc: linux-kernel , Andrew Morton Subject: [Patch 5/7] driver core: Change function call order in device_bind_driver(). Message-ID: <20061027133654.648038e8@gondolin.boeblingen.de.ibm.com> X-Mailer: Sylpheed-Claws 2.5.6 (GTK+ 2.8.20; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org From: Cornelia Huck Change function call order in device_bind_driver(). If we create symlinks (which might fail) before adding the device to the list we don't have to clean up afterwards (which we didn't). Signed-off-by: Cornelia Huck --- drivers/base/dd.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) --- linux-2.6.orig/drivers/base/dd.c +++ linux-2.6/drivers/base/dd.c @@ -85,8 +85,12 @@ static void driver_sysfs_remove(struct d */ int device_bind_driver(struct device *dev) { - driver_bound(dev); - return driver_sysfs_add(dev); + int ret; + + ret = driver_sysfs_add(dev); + if (!ret) + driver_bound(dev); + return ret; } struct stupid_thread_structure {