-stable review patch. If anyone has any objections, please let us know. ------------------ From: Jens Axboe Don't jump to the unlock+release path, we already did that. Signed-off-by: Jens Axboe Signed-off-by: Greg Kroah-Hartman Signed-off-by: Chris Wright --- fs/splice.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- linux-2.6.18.1.orig/fs/splice.c +++ linux-2.6.18.1/fs/splice.c @@ -607,7 +607,7 @@ find_page: ret = -ENOMEM; page = page_cache_alloc_cold(mapping); if (unlikely(!page)) - goto out_nomem; + goto out_ret; /* * This will also lock the page @@ -666,7 +666,7 @@ find_page: if (sd->pos + this_len > isize) vmtruncate(mapping->host, isize); - goto out; + goto out_ret; } if (buf->page != page) { @@ -698,7 +698,7 @@ find_page: out: page_cache_release(page); unlock_page(page); -out_nomem: +out_ret: return ret; } --