From: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
To: Holden Karau <holden@pigscanfly.ca>
Cc: Josef Sipek <jsipek@fsl.cs.sunysb.edu>,
hirofumi@mail.parknet.co.jp, linux-kernel@vger.kernel.org,
Holden Karau <holdenk@xandros.com>,
"akpm@osdl.org" <akpm@osdl.org>,
linux-fsdevel@vger.kernel.org,
Nick Piggin <nickpiggin@yahoo.com.au>,
Matthew Wilcox <matthew@wil.cx>
Subject: Re: [PATCH 1/1] fat: improve sync performance by grouping writes revised again
Date: Wed, 1 Nov 2006 21:24:00 +0100 [thread overview]
Message-ID: <20061101202400.GA6888@wohnheim.fh-wedel.de> (raw)
In-Reply-To: <f46018bb0611011002h1b3b6e5fjdc6cc032a7503dbd@mail.gmail.com>
On Wed, 1 November 2006 13:02:12 -0500, Holden Karau wrote:
> On 11/1/06, Jörn Engel <joern@wohnheim.fh-wedel.de> wrote:
> >
> >Result would be something like:
> > c_bh = kmalloc(...
> > err = -ENOMEM;
> > if (!c_bh)
> > goto error;
> That wouldn't work so well since we always return err,
I don't quite follow. If the branch is taken, err is -ENOMEM. If the
branch is not taken, err is set to 0 with the next instruction.
Both methods definitely work. Whether one is preferrable over the
other is imo 90% taste and maybe 10% better code on some architecture.
So just pick what you prefer.
Jörn
--
Unless something dramatically changes, by 2015 we'll be largely
wondering what all the fuss surrounding Linux was really about.
-- Rob Enderle
next prev parent reply other threads:[~2006-11-01 20:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-01 16:17 Holden Karau
2006-11-01 16:47 ` Jörn Engel
2006-11-01 18:02 ` Holden Karau
2006-11-01 20:24 ` Jörn Engel [this message]
2006-11-01 20:52 ` Phillip Susi
2006-11-01 22:17 ` Holden Karau
2006-11-02 10:24 ` historical micro-optimizations (Re: [PATCH 1/1] fat: improve sync performance by grouping writes revised again) Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061101202400.GA6888@wohnheim.fh-wedel.de \
--to=joern@wohnheim.fh-wedel.de \
--cc=akpm@osdl.org \
--cc=hirofumi@mail.parknet.co.jp \
--cc=holden@pigscanfly.ca \
--cc=holdenk@xandros.com \
--cc=jsipek@fsl.cs.sunysb.edu \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=nickpiggin@yahoo.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®