From: Jesper Juhl <jesper.juhl@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Jay Schulist <jschlst@samba.org>,
Arnaldo Carvalho de Melo <acme@conectiva.com.br>,
davem@davemloft.net, Jesper Juhl <jesper.juhl@gmail.com>
Subject: [PATCH] LLC: Avoid potential NULL dereference in net/llc/af_llc.c::llc_ui_accept() .
Date: Thu, 2 Nov 2006 01:21:53 +0100 [thread overview]
Message-ID: <200611020121.53368.jesper.juhl@gmail.com> (raw)
Since skb_dequeue() may return NULL we risk dereferencing a NULL pointer at
if (!skb->sk)
This patch avoids that by also testing for a NULL skb.
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
---
diff --git a/net/llc/af_llc.c b/net/llc/af_llc.c
index 2652ead..a3c885f 100644
--- a/net/llc/af_llc.c
+++ b/net/llc/af_llc.c
@@ -620,7 +620,7 @@ static int llc_ui_accept(struct socket *
llc_sk(sk)->laddr.lsap);
skb = skb_dequeue(&sk->sk_receive_queue);
rc = -EINVAL;
- if (!skb->sk)
+ if (!skb || !skb->sk)
goto frees;
rc = 0;
newsk = skb->sk;
next reply other threads:[~2006-11-02 0:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-02 0:21 Jesper Juhl [this message]
2006-11-02 0:27 ` David Miller
2006-11-02 0:30 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200611020121.53368.jesper.juhl@gmail.com \
--to=jesper.juhl@gmail.com \
--cc=acme@conectiva.com.br \
--cc=davem@davemloft.net \
--cc=jschlst@samba.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®