From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751086AbWKBOqY (ORCPT ); Thu, 2 Nov 2006 09:46:24 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751079AbWKBOqY (ORCPT ); Thu, 2 Nov 2006 09:46:24 -0500 Received: from palrel10.hp.com ([156.153.255.245]:1261 "EHLO palrel10.hp.com") by vger.kernel.org with ESMTP id S1751046AbWKBOqX (ORCPT ); Thu, 2 Nov 2006 09:46:23 -0500 Date: Thu, 2 Nov 2006 08:46:23 -0600 From: "Mike Miller (OS Dev)" To: Jens Axboe Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH 1/8] cciss: version number change Message-ID: <20061102144623.GC16430@beardog.cca.cpqcorp.net> References: <20061101214913.GA29928@beardog.cca.cpqcorp.net> <20061102141045.GH13555@kernel.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20061102141045.GH13555@kernel.dk> User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 02, 2006 at 03:10:45PM +0100, Jens Axboe wrote: > On Wed, Nov 01 2006, Mike Miller (OS Dev) wrote: > > > > PATCH 1/8 > > > > This patch changes the cciss version number to 3.6.14 to reflect the following > > functionality changes added by the rest of the set. They include: > > Mike, only some of your patches appeared to go out, both in personal > mail and on the list. I ran into some last minute issues so I stopped at 5. Still re-testing the others. This snippet seems to tbe the culprit. + if (blk_queue_stopped(h->gendisk[curr_queue]->queue) || + blk_queue_plugged(h->gendisk[curr_queue]->queue)) + blk_start_queue(h->gendisk[curr_queue]->queue); We're testing to see if the queue is stopped or plugged so we don't try to start am already running queue. Without the blk_queue_plugged test it hangs every time. We added blk_queue_plugged and the first tests seem to run ok. Then at the last minute something broke. Does this look ok to you? > > Comment on this patch - normally you'd change the version number last, > not as the first patch. Yep, put the cart before horse I suppose. Maybe I shouldn't have a version number at all. :) mikem