From: Josef Sipek <jsipek@fsl.cs.sunysb.edu>
To: Mark Williamson <mark.williamson@cl.cam.ac.uk>
Cc: Trond Myklebust <trond.myklebust@fys.uio.no>,
linux-kernel@vger.kernel.org,
Pekka Enberg <penberg@cs.helsinki.fi>,
Michael Halcrow <mhalcrow@us.ibm.com>,
Erez Zadok <ezk@cs.sunysb.edu>,
Christoph Hellwig <hch@infradead.org>,
Al Viro <viro@ftp.linux.org.uk>, Andrew Morton <akpm@osdl.org>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/3] fsstack: Generic get/set lower object functions
Date: Thu, 2 Nov 2006 22:51:30 -0500 [thread overview]
Message-ID: <20061103035130.GC13499@filer.fsl.cs.sunysb.edu> (raw)
In-Reply-To: <200611030345.51167.mark.williamson@cl.cam.ac.uk>
On Fri, Nov 03, 2006 at 03:45:50AM +0000, Mark Williamson wrote:
> > > Why are you defining all these structs that are just wrapping unions?
> >
> > The reason for the union is simple...
...
> I guess that having a union foo * rather than a struct foo * would be a bit
> unconventional in the kernel. The named struct / anonymous union combo does
> hide the union as merely an implementation detail, which is nice. Was this
> your motivation?
That's exactly it. Save space & hide the details.
Josef "Jeff" Sipek.
--
Once you have their hardware. Never give it back.
(The First Rule of Hardware Acquisition)
next prev parent reply other threads:[~2006-11-03 3:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-02 3:59 [PATCH 0/3] fsstack updates Josef Jeff Sipek
2006-11-02 3:59 ` [PATCH 1/3] fsstack: Make fsstack_copy_attr_all copy inode size Josef Jeff Sipek
2006-11-02 3:59 ` [PATCH 2/3] fsstack: Generic get/set lower object functions Josef Jeff Sipek
2006-11-02 16:06 ` Trond Myklebust
2006-11-03 3:27 ` Josef Sipek
2006-11-03 3:45 ` Mark Williamson
2006-11-03 3:51 ` Josef Sipek [this message]
2006-11-03 6:25 ` Trond Myklebust
2006-11-03 9:13 ` Pekka Enberg
2006-11-03 16:36 ` Jan Engelhardt
2006-11-03 20:47 ` Josef Sipek
2006-11-03 21:22 ` Trond Myklebust
2006-11-02 3:59 ` [PATCH 3/3] fsstack: Make ecryptfs a user of new fsstack_* functions Josef Jeff Sipek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061103035130.GC13499@filer.fsl.cs.sunysb.edu \
--to=jsipek@fsl.cs.sunysb.edu \
--cc=akpm@osdl.org \
--cc=ezk@cs.sunysb.edu \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.williamson@cl.cam.ac.uk \
--cc=mhalcrow@us.ibm.com \
--cc=penberg@cs.helsinki.fi \
--cc=trond.myklebust@fys.uio.no \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®