mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andreas Gruenbacher <agruen@suse.de>
To: Timothy Shimmin <tes@sgi.com>
Cc: linux-kernel@vger.kernel.org, Gerard Neil <xyzzy@devferret.org>,
	Dave Kleikamp <shaggy@austin.ibm.com>,
	Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] Fix user.* xattr permission check for sticky dirs
Date: Fri, 3 Nov 2006 09:38:58 +0100	[thread overview]
Message-ID: <200611030938.58873.agruen@suse.de> (raw)
In-Reply-To: <BA8CE04BC202FBB09918854E@timothy-shimmins-power-mac-g5.local>

On Friday 03 November 2006 05:57, Timothy Shimmin wrote:
> > so this added the check to the xfs_getxattr() path by accident:
> >
> > []	if (!S_ISREG(inode->i_mode) &&
> > []	    (!S_ISDIR(inode->i_mode) || inode->i_mode & S_ISVTX))
> > []		return -EPERM;
>
> Now, I'm a bit confused.
> xfs_getxattr?
> I see the "correct" version of the test in xfs_attr.c/attr_user_capable().

I meant to say fs/xattr.c:vfs_getxattr() and fs/xattr.c:vfs_setxattr(), sorry. 
The xfs code is fine, it just contains the same check once again in 
fs/xfs/xfs_attr.c:attr_user_capable().

Thanks,
Andreas

      reply	other threads:[~2006-11-03  8:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-02 16:24 Andreas Gruenbacher
2006-11-02 16:59 ` Jan Engelhardt
2006-11-02 17:14   ` Dave Kleikamp
2006-11-02 19:27 ` Andrew Morton
2006-11-02 21:51   ` Andreas Gruenbacher
2006-11-03  4:57     ` Timothy Shimmin
2006-11-03  8:38       ` Andreas Gruenbacher [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200611030938.58873.agruen@suse.de \
    --to=agruen@suse.de \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shaggy@austin.ibm.com \
    --cc=tes@sgi.com \
    --cc=torvalds@osdl.org \
    --cc=xyzzy@devferret.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®