From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932670AbWKEL6S (ORCPT ); Sun, 5 Nov 2006 06:58:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932672AbWKEL6S (ORCPT ); Sun, 5 Nov 2006 06:58:18 -0500 Received: from gprs189-60.eurotel.cz ([160.218.189.60]:40376 "EHLO amd.ucw.cz") by vger.kernel.org with ESMTP id S932670AbWKEL6R (ORCPT ); Sun, 5 Nov 2006 06:58:17 -0500 Date: Sun, 5 Nov 2006 12:58:04 +0100 From: Pavel Machek To: "Rafael J. Wysocki" Cc: LKML , linux-raid@vger.kernel.org Subject: Re: [RFC][PATCH -mm][Experimental] suspend: Do not freeze md_threads Message-ID: <20061105115804.GG4965@elf.ucw.cz> References: <200611022355.52856.rjw@sisk.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200611022355.52856.rjw@sisk.pl> X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.11+cvs20060126 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hi! > If there's a swap file on a software RAID, it should be possible to use this > file for saving the swsusp's suspend image. Also, this file should be > available to the memory management subsystem when memory is being freed before > the suspend image is created. > > For the above reasons it seems that md_threads should not be frozen during > the suspend and the appended patch makes this happen, but then there is the > question if they don't cause any data to be written to disks after the > suspend image has been created, provided that all filesystems are frozen > at that time. Looks okay to me. It would be nice to have someone (Ingo? Neil?) try to suspend to swap on md...... Pavel > Please advise. > > Greetings, > Rafael > > > Signed-off-by: Rafael J. Wysocki > --- > drivers/md/md.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: linux-2.6.19-rc4-mm2/drivers/md/md.c > =================================================================== > --- linux-2.6.19-rc4-mm2.orig/drivers/md/md.c 2006-11-02 20:51:51.000000000 +0100 > +++ linux-2.6.19-rc4-mm2/drivers/md/md.c 2006-11-02 23:25:59.000000000 +0100 > @@ -4489,6 +4489,7 @@ static int md_thread(void * arg) > * many dirty RAID5 blocks. > */ > > + current->flags |= PF_NOFREEZE; > allow_signal(SIGKILL); > while (!kthread_should_stop()) { > > @@ -4505,7 +4506,6 @@ static int md_thread(void * arg) > test_bit(THREAD_WAKEUP, &thread->flags) > || kthread_should_stop(), > thread->timeout); > - try_to_freeze(); > > clear_bit(THREAD_WAKEUP, &thread->flags); > -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html