From: Ingo Molnar <mingo@elte.hu>
To: Mike Galbraith <efault@gmx.de>
Cc: Rui Nuno Capela <rncbc@rncbc.org>,
Daniel Walker <dwalker@mvista.com>,
linux-kernel@vger.kernel.org,
Karsten Wiese <fzu@wemgehoertderstaat.de>
Subject: Re: realtime-preempt patch-2.6.18-rt7 oops
Date: Mon, 6 Nov 2006 10:38:15 +0100 [thread overview]
Message-ID: <20061106093815.GB14388@elte.hu> (raw)
In-Reply-To: <1162797896.6126.5.camel@Homer.simpson.net>
* Mike Galbraith <efault@gmx.de> wrote:
> I just reproduced it running glibc make check. I had just enabled
> kprobes and recompiled with the stock SuSE-10.1 compiler while waiting
> for you to send me your .config (nevermind that request) so I could
> try to reproduce it here.
hm, so kprobe_flush_task() is likely PREEMPT_RT-unsafe.
could you try the patch below, does it help? (a quick review seems to
suggest that all codepaths protected by kretprobe_lock are atomic)
Ingo
Index: linux/kernel/kprobes.c
===================================================================
--- linux.orig/kernel/kprobes.c
+++ linux/kernel/kprobes.c
@@ -50,7 +50,7 @@ static struct hlist_head kretprobe_inst_
static atomic_t kprobe_count;
DEFINE_MUTEX(kprobe_mutex); /* Protects kprobe_table */
-DEFINE_SPINLOCK(kretprobe_lock); /* Protects kretprobe_inst_table */
+DEFINE_RAW_SPINLOCK(kretprobe_lock); /* Protects kretprobe_inst_table */
static DEFINE_PER_CPU(struct kprobe *, kprobe_instance) = NULL;
static struct notifier_block kprobe_page_fault_nb = {
next prev parent reply other threads:[~2006-11-06 9:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-02 10:43 Rui Nuno Capela
2006-11-03 11:30 ` Karsten Wiese
2006-11-03 22:55 ` Rui Nuno Capela
2006-11-04 2:08 ` Rui Nuno Capela
2006-11-04 10:54 ` Rui Nuno Capela
2006-11-04 15:08 ` Karsten Wiese
2006-11-05 15:55 ` Rui Nuno Capela
2006-11-05 16:47 ` Rui Nuno Capela
2006-11-05 16:02 ` Daniel Walker
2006-11-05 18:38 ` Rui Nuno Capela
2006-11-05 18:18 ` Daniel Walker
2006-11-06 7:24 ` Mike Galbraith
2006-11-06 9:38 ` Ingo Molnar [this message]
2006-11-06 10:02 ` Mike Galbraith
2006-11-06 10:11 ` Ingo Molnar
2006-11-06 10:26 ` Mike Galbraith
2006-11-10 9:31 ` Rui Nuno Capela
2006-11-10 9:33 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061106093815.GB14388@elte.hu \
--to=mingo@elte.hu \
--cc=dwalker@mvista.com \
--cc=efault@gmx.de \
--cc=fzu@wemgehoertderstaat.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rncbc@rncbc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®