From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Hoang-Nam Nguyen <hnguyen@de.ibm.com>
Cc: rolandd@cisco.com, linux-kernel@vger.kernel.org,
linuxppc-dev@ozlabs.org, openib-general@openib.org,
raisch@de.ibm.com
Subject: Re: [PATCH 2.6.19 1/4] ehca: assure 4k alignment for firmware control block in 64k page mode
Date: Mon, 6 Nov 2006 15:58:39 +0100 [thread overview]
Message-ID: <20061106145839.GA9387@osiris.boeblingen.de.ibm.com> (raw)
In-Reply-To: <200611052140.38445.hnguyen@de.ibm.com>
> +#ifdef CONFIG_PPC_64K_PAGES
> +void *ehca_alloc_fw_ctrlblock(void);
> +void ehca_free_fw_ctrlblock(void *ptr);
> +#else
> +#define ehca_alloc_fw_ctrlblock() get_zeroed_page(GFP_KERNEL)
> +#define ehca_free_fw_ctrlblock(ptr) free_page((unsigned long)(ptr))
> +#endif
Maybe you want to make sure that ehca_alloc_fw_ctrlblock() always returns a
void pointer, so you can avoid all the casts in your code?
static inline void *ehca_alloc_fw_ctrlblock(void)
{
return (void *)get_zeroed_page(GFP_KERNEL);
}
next prev parent reply other threads:[~2006-11-06 15:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-05 20:40 Hoang-Nam Nguyen
2006-11-05 23:45 ` Arnd Bergmann
2006-11-06 10:00 ` Hoang-Nam Nguyen
2006-11-06 10:39 ` Hoang-Nam Nguyen
2006-11-06 16:51 ` Roland Dreier
2006-11-06 17:45 ` Hoang-Nam Nguyen
2006-11-06 16:50 ` Roland Dreier
2006-11-06 14:58 ` Heiko Carstens [this message]
2006-11-06 16:13 ` Hoang-Nam Nguyen
2006-11-06 21:26 Hoang-Nam Ngyuen
2006-11-06 21:35 ` Arnd Bergmann
2006-11-06 23:56 ` Hoang-Nam Ngyuen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061106145839.GA9387@osiris.boeblingen.de.ibm.com \
--to=heiko.carstens@de.ibm.com \
--cc=hnguyen@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=openib-general@openib.org \
--cc=raisch@de.ibm.com \
--cc=rolandd@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®