From: Thomas Petazzoni <thomas.petazzoni@enix.org>
To: sam@ravnborg.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] Keep the kernel configuration test undisplayed when V=1
Date: Tue, 7 Nov 2006 11:58:10 +0100 [thread overview]
Message-ID: <20061107115810.6d6474a1@thomas.toulouse> (raw)
Keep the kernel configuration test undisplayed when V=1
While compiling external modules with V=1, during the compilation
process, one can see something such as:
make: Entering directory `/usr/src/linux-2.6.18.2'
test -e include/linux/autoconf.h -a -e include/config/auto.conf || ( \
echo; \
echo " ERROR: Kernel configuration is invalid."; \
echo " include/linux/autoconf.h or include/config/auto.conf are missing."; \
echo " Run 'make oldconfig && make prepare' on kernel src to fix it."; \
echo; \
/bin/false)
Such a display is quite misleading: it took me a while to understand
that there was in fact no error: it was just the code that tests for
the error that was displayed.
In order for others to not be annoyed by the same thing, I suggest to
simply remove the $(Q) before the test, and to force it to be prefixed
by @.
The drawback is that it violates the rule saying that V=1 should
display every command executed.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@enix.org>
---
Makefile | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6.18.2/Makefile
===================================================================
--- linux-2.6.18.2.orig/Makefile 2006-11-04 02:33:58.000000000 +0100
+++ linux-2.6.18.2/Makefile 2006-11-07 11:52:28.000000000 +0100
@@ -456,7 +456,7 @@
PHONY += include/config/auto.conf
include/config/auto.conf:
- $(Q)test -e include/linux/autoconf.h -a -e $@ || ( \
+ @test -a include/linux/autoconf.h -a -e $@ || ( \
echo; \
echo " ERROR: Kernel configuration is invalid."; \
echo " include/linux/autoconf.h or $@ are missing."; \
--
Thomas Petazzoni - thomas.petazzoni@enix.org
http://{thomas,sos,kos}.enix.org - http://www.toulibre.org
http://www.{livret,agenda}dulibre.org
reply other threads:[~2006-11-07 10:58 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061107115810.6d6474a1@thomas.toulouse \
--to=thomas.petazzoni@enix.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®