mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alistair John Strachan <s0348365@sms.ed.ac.uk>
To: Ludovic Drolez <ludovic.drolez@linbox.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	trivial@kernel.org
Subject: Re: 2.6.18.2: cannot compile with gcc 3.0.4
Date: Fri, 10 Nov 2006 15:22:39 +0000	[thread overview]
Message-ID: <200611101522.39821.s0348365@sms.ed.ac.uk> (raw)
In-Reply-To: <455468D8.7080609@linbox.com>

On Friday 10 November 2006 11:56, Ludovic Drolez wrote:
> Jesper Juhl wrote:
> > If you had bothered to read Documentation/Changes then you would have
> > seen that the current minimal required gcc version is 3.2 :
>
> Ok sorry, I didn't see the change between 2.6.15 and 2.6.16.
> Maybe a test should be added in linux/compiler-gcc3.h, to have the same
> warning as with gcc 2.xx ?

Untested, but something like this should do it.

The kernel doesn't compile with GCC <3.2, do not allow it to succeed if GCC 
3.0.x or 3.1.x are used.

Signed-off-by: Alistair John Strachan <s0348365@sms.ed.ac.uk>

diff --git a/include/linux/compiler.h b/include/linux/compiler.h
index 538423d..aca6698 100644
--- a/include/linux/compiler.h
+++ b/include/linux/compiler.h
@@ -40,7 +40,7 @@ #if __GNUC__ > 4
 #error no compiler-gcc.h file for this gcc version
 #elif __GNUC__ == 4
 # include <linux/compiler-gcc4.h>
-#elif __GNUC__ == 3
+#elif __GNUC__ == 3 && __GNUC_MINOR__ >= 2
 # include <linux/compiler-gcc3.h>
 #else
 # error Sorry, your compiler is too old/not recognized.

-- 
Cheers,
Alistair.

Final year Computer Science undergraduate.
1F2 55 South Clerk Street, Edinburgh, UK.

      reply	other threads:[~2006-11-10 15:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-10 11:01 Ludovic Drolez
2006-11-10 11:28 ` Jesper Juhl
2006-11-10 11:56   ` Ludovic Drolez
2006-11-10 15:22     ` Alistair John Strachan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200611101522.39821.s0348365@sms.ed.ac.uk \
    --to=s0348365@sms.ed.ac.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ludovic.drolez@linbox.com \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®