From: Kristen Carlson Accardi <kristen.c.accardi@intel.com>
To: jgarzik@pobox.com, akpm@osdl.org
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
rdunlap@xenotime.net, mjg59@srcf.ucam.org
Subject: [patch] libata: change order of _SDD/_GTF execution (resend #3)
Date: Fri, 10 Nov 2006 16:14:47 -0800 [thread overview]
Message-ID: <20061110161447.b4599cbd.kristen.c.accardi@intel.com> (raw)
In-Reply-To: <20060929021353.GB22082@srcf.ucam.org>
Make the sdd call come before gtf. _SDD is used to provide
input to the _GTF file, so it should be executed first.
Signed-off-by: Kristen Carlson Accardi <kristen.c.accardi@intel.com>
---
drivers/ata/libata-core.c | 21 ++++++++++-----------
1 file changed, 10 insertions(+), 11 deletions(-)
--- 2.6-mm.orig/drivers/ata/libata-core.c
+++ 2.6-mm/drivers/ata/libata-core.c
@@ -1411,6 +1411,16 @@ int ata_dev_configure(struct ata_device
ata_dev_printk(dev, KERN_DEBUG, "%s: ENTER, host %u, dev %u\n",
__FUNCTION__, ap->id, dev->devno);
+ /* set _SDD */
+ rc = ata_acpi_push_id(ap, dev->devno);
+ if (rc) {
+ ata_dev_printk(dev, KERN_WARNING, "failed to set _SDD(%d)\n",
+ rc);
+ }
+
+ /* retrieve and execute the ATA task file of _GTF */
+ ata_acpi_exec_tfs(ap);
+
/* print device capabilities */
if (ata_msg_probe(ap))
ata_dev_printk(dev, KERN_DEBUG,
@@ -1568,14 +1578,6 @@ int ata_dev_configure(struct ata_device
if (ap->ops->dev_config)
ap->ops->dev_config(ap, dev);
- /* set _SDD */
- rc = ata_acpi_push_id(ap, dev->devno);
- if (rc) {
- ata_dev_printk(dev, KERN_WARNING, "failed to set _SDD(%d)\n",
- rc);
- goto err_out_nosup;
- }
-
if (ata_msg_probe(ap))
ata_dev_printk(dev, KERN_DEBUG, "%s: EXIT, drv_stat = 0x%x\n",
__FUNCTION__, ata_chk_status(ap));
@@ -1621,9 +1623,6 @@ int ata_bus_probe(struct ata_port *ap)
/* reset and determine device classes */
ap->ops->phy_reset(ap);
- /* retrieve and execute the ATA task file of _GTF */
- ata_acpi_exec_tfs(ap);
-
for (i = 0; i < ATA_MAX_DEVICES; i++) {
dev = &ap->device[i];
next prev parent reply other threads:[~2006-11-11 0:15 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060928182211.076258000@localhost.localdomain>
2006-09-28 18:29 ` [patch 1/2] libata: _GTF support Kristen Carlson Accardi
2006-09-28 18:51 ` Diego Calleja
2006-09-28 20:32 ` Jeff Garzik
2006-09-28 20:39 ` Jeff Garzik
2006-09-29 2:07 ` Matthew Garrett
2006-09-29 16:54 ` Kristen Carlson Accardi
2006-09-29 17:04 ` Randy Dunlap
2006-09-29 17:03 ` Kristen Carlson Accardi
2006-10-01 17:02 ` Andrey Borzenkov
2006-10-02 16:45 ` Kristen Carlson Accardi
2006-10-02 13:06 ` Pavel Machek
2006-09-28 18:29 ` [patch 2/2] libata: _SDD support Kristen Carlson Accardi
2006-09-29 2:13 ` Matthew Garrett
2006-09-30 0:33 ` Kristen Carlson Accardi
2006-11-11 0:14 ` Kristen Carlson Accardi [this message]
2006-11-14 19:19 ` [patch] libata: change order of _SDD/_GTF execution (resend #3) Jeff Garzik
2006-10-02 13:08 ` [patch 2/2] libata: _SDD support Pavel Machek
2006-09-28 18:29 ` [patch 1/2] libata: _GTF support Kristen Carlson Accardi
2006-09-28 18:30 ` Kristen Carlson Accardi
2006-09-28 18:30 ` [patch 2/2] libata: _SDD support Kristen Carlson Accardi
2006-09-29 17:56 ` Valdis.Kletnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061110161447.b4599cbd.kristen.c.accardi@intel.com \
--to=kristen.c.accardi@intel.com \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®