mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Luca Tettamanti <kronos.it@gmail.com>
To: Vojtech Pavlik <vojtech@suse.cz>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH] atkbd: disable spurious ACK/NAK warning on panic
Date: Mon, 13 Nov 2006 21:43:40 +0100	[thread overview]
Message-ID: <20061113204340.GA25557@dreamland.darkstar.lan> (raw)

After the panic() message has been printed kernel may blink keyboard
leds to signal the abnormal condition.
atkbd warns that "Some program might be trying access hardware directly"
at every blink, scrolling the useful text out of the screen.
Avoid printing the warning when oops_in_progress is set in order to
preserve the panic message.

Signed-Off-By: Luca Tettamanti <kronos.it@gmail.com>

---
 Patch against current GIT tree.

 drivers/input/keyboard/atkbd.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c
index cbb9366..81d2701 100644
--- a/drivers/input/keyboard/atkbd.c
+++ b/drivers/input/keyboard/atkbd.c
@@ -412,6 +412,8 @@ static irqreturn_t atkbd_interrupt(struc
 			goto out;
 		case ATKBD_RET_ACK:
 		case ATKBD_RET_NAK:
+			if (oops_in_progress)
+				goto out;
 			printk(KERN_WARNING "atkbd.c: Spurious %s on %s. "
 			       "Some program might be trying access hardware directly.\n",
 			       data == ATKBD_RET_ACK ? "ACK" : "NAK", serio->phys);


Luca
-- 
"In linea di principio sarei indifferente al natale, se solo il natale
 ricambiasse la cortesia e mi lasciasse in pace." -- Marco d'Itri

             reply	other threads:[~2006-11-13 20:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-13 20:43 Luca Tettamanti [this message]
2006-11-13 21:24 ` Dmitry Torokhov
2006-11-13 21:39   ` Luca Tettamanti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061113204340.GA25557@dreamland.darkstar.lan \
    --to=kronos.it@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vojtech@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®