From: Christoph Hellwig <hch@infradead.org>
To: Alexey Dobriyan <adobriyan@openvz.org>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, devel@openvz.org
Subject: Re: [PATCH] Don't give bad kprobes example aka ") < 0))" typo
Date: Wed, 15 Nov 2006 11:57:16 +0000 [thread overview]
Message-ID: <20061115115716.GA923@infradead.org> (raw)
In-Reply-To: <20061115155619.GC9011@localhost.sw.ru>
On Wed, Nov 15, 2006 at 06:56:19PM +0300, Alexey Dobriyan wrote:
> Signed-off-by: Alexey Dobriyan <adobriyan@openvz.org>
> ---
>
> Documentation/kprobes.txt | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> --- a/Documentation/kprobes.txt
> +++ b/Documentation/kprobes.txt
> @@ -442,9 +442,10 @@ static int __init kprobe_init(void)
> kp.fault_handler = handler_fault;
> kp.symbol_name = "do_fork";
>
> - if ((ret = register_kprobe(&kp) < 0)) {
> + ret = register_kprobe(&kp);
> + if (ret < 0) {
> printk("register_kprobe failed, returned %d\n", ret);
> - return -1;
> + return ret;
This looks good, thanks.
prev parent reply other threads:[~2006-11-15 11:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-15 15:56 Alexey Dobriyan
2006-11-15 11:57 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061115115716.GA923@infradead.org \
--to=hch@infradead.org \
--cc=adobriyan@openvz.org \
--cc=akpm@osdl.org \
--cc=devel@openvz.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®