mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mattia Dongili <malattia@linux.it>
To: "Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>
Cc: ego@in.ibm.com, Reuben Farrelly <reuben-linuxkernel@reub.net>,
	Andrew Morton <akpm@osdl.org>,
	davej@redhat.com, linux-kernel@vger.kernel.org,
	CPUFreq Mailing List <cpufreq@lists.linux.org.uk>,
	"Sadykov, Denis M" <denis.m.sadykov@intel.com>
Subject: Re: 2.6.19-rc5-mm2
Date: Wed, 15 Nov 2006 19:36:10 +0100	[thread overview]
Message-ID: <20061115183610.GA4812@inferi.kami.home> (raw)
In-Reply-To: <EB12A50964762B4D8111D55B764A8454E4128E@scsmsx413.amr.corp.intel.com>

On Wed, Nov 15, 2006 at 10:06:23AM -0800, Pallipadi, Venkatesh wrote:
[...]
> >Venki, I'm a little worried about the switch/case in question (line
> >702): the data->cpu_feature is set either to SYSTEM_IO_CAPABLE or
> >SYSTEM_INTEL_MSR_CAPABLE just a few lines above so it seems the switch
> >variable is wrong and none of the 2 cases will ever get a chance to
> >execute.
> >
> 
> The variable is set few lines before. So, it should be OK to switch on
> that 
> variable set and one of the two cases will execute. isn't it? Or am 
> I missing something?

Yes, patch is coming.

> >Unfortunately I don't have enough knowledge to tell if it's simply
> >necessary to fix the switch variable as 
> 
> Get_cur_freq_on_cpu will not work on SYSTEM_IO space as ACPI does not
> have an interface to get the current frequency. It only has a interface
> to say whether the last transitions tried was successful or not.
> So, if indeed a change in switch is required, first option should be
> good...

Hmmmm... I see, the following path fooled me, but re-reading it seems
more obvious what it is doing :)

	get_cur_freq_on_cpu
		extract_freq
			switch (data->cpu_feature) {
			case SYSTEM_INTEL_MSR_CAPABLE:
				return extract_msr(val, data);
			case SYSTEM_IO_CAPABLE:
				return extract_io(val, data);
			...

-- 
mattia
:wq!

  reply	other threads:[~2006-11-15 18:36 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-15 18:06 2.6.19-rc5-mm2 Pallipadi, Venkatesh
2006-11-15 18:36 ` Mattia Dongili [this message]
2006-11-15 19:05   ` [PATCH 2.6.19-rc5-mm2] cpufreq: set policy->curfreq on initialization Mattia Dongili
2006-11-17 13:56     ` Reuben Farrelly
  -- strict thread matches above, loose matches on Subject: below --
2006-11-15 14:09 2.6.19-rc5-mm2 Pallipadi, Venkatesh
2006-11-15 17:46 ` 2.6.19-rc5-mm2 Mattia Dongili
2006-11-14  9:41 2.6.19-rc5-mm2 Andrew Morton
2006-11-14 11:11 ` 2.6.19-rc5-mm2 Jiri Slaby
2006-11-14 11:54   ` 2.6.19-rc5-mm2 Jiri Slaby
2006-11-14 11:31 ` 2.6.19-rc5-mm2 Reuben Farrelly
2006-11-14 17:00   ` 2.6.19-rc5-mm2 Gautham R Shenoy
2006-11-14 20:58     ` 2.6.19-rc5-mm2 Mattia Dongili
2006-11-15 10:34       ` 2.6.19-rc5-mm2 Gautham R Shenoy
2006-11-15 10:42         ` 2.6.19-rc5-mm2 Reuben Farrelly
2006-11-14 12:46 ` 2.6.19-rc5-mm2 Mariusz Kozlowski
2006-11-14 13:07   ` 2.6.19-rc5-mm2 Mariusz Kozlowski
2006-11-14 16:41   ` 2.6.19-rc5-mm2 Andrew Morton
2006-11-14 17:09     ` 2.6.19-rc5-mm2 Andrew Morton
2006-11-14 19:23       ` 2.6.19-rc5-mm2 Mariusz Kozlowski
2006-11-14 13:50 ` 2.6.19-rc5-mm2 Eric Dumazet
2006-11-16 17:17 ` 2.6.19-rc5-mm2 Mattia Dongili
2006-11-16 18:29   ` 2.6.19-rc5-mm2 Stefan Richter
2006-11-16 20:39     ` 2.6.19-rc5-mm2 Mattia Dongili
2006-11-16 22:50       ` 2.6.19-rc5-mm2 Stefan Richter
2006-11-17  7:16         ` 2.6.19-rc5-mm2 Mattia Dongili
2006-11-17 15:02           ` 2.6.19-rc5-mm2 Stefan Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061115183610.GA4812@inferi.kami.home \
    --to=malattia@linux.it \
    --cc=akpm@osdl.org \
    --cc=cpufreq@lists.linux.org.uk \
    --cc=davej@redhat.com \
    --cc=denis.m.sadykov@intel.com \
    --cc=ego@in.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=reuben-linuxkernel@reub.net \
    --cc=venkatesh.pallipadi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®