From: Eric Dumazet <dada1@cosmosbay.com>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix strange size check in __get_vm_area_node()
Date: Wed, 15 Nov 2006 18:51:09 +0100 [thread overview]
Message-ID: <200611151851.09649.dada1@cosmosbay.com> (raw)
In-Reply-To: <87k61wa9to.fsf@duaron.myhome.or.jp>
On Wednesday 15 November 2006 18:39, OGAWA Hirofumi wrote:
> Recently, __get_vm_area_node() was changed like following
>
> if (unlikely(!area))
> return NULL;
>
> - if (unlikely(!size)) {
> - kfree (area);
> + if (unlikely(!size))
> return NULL;
> - }
>
> It is leaking `area', also original code seems strange already.
> Probably, we wanted to do this patch.
>
Indeed. I checked my original patch and it was correct. I dont know what
happened then...
http://lkml.org/lkml/2006/10/23/86
Eric
prev parent reply other threads:[~2006-11-15 17:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-15 17:39 OGAWA Hirofumi
2006-11-15 17:51 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200611151851.09649.dada1@cosmosbay.com \
--to=dada1@cosmosbay.com \
--cc=akpm@osdl.org \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®