From: Andrew Morton <akpm@osdl.org>
To: Avi Kivity <avi@qumranet.com>
Cc: kvm-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
uril@qumranet.com
Subject: Re: [PATCH 3/3] KVM: Expose MSRs to userspace
Date: Fri, 17 Nov 2006 00:15:10 -0800 [thread overview]
Message-ID: <20061117001510.58f01b3c.akpm@osdl.org> (raw)
In-Reply-To: <455D62D1.6040203@qumranet.com>
On Fri, 17 Nov 2006 09:20:49 +0200
Avi Kivity <avi@qumranet.com> wrote:
> >> +out_vcpu:
> >> + vcpu_put(vcpu);
> >> +
> >> + return rc;
> >> +}
> >>
> >
> > This function returns no indication of how many msrs it actually did set.
> > Should it?
> >
>
> It can't hurt. Is returning the number of msrs set in the return code
> (ala short write) acceptable, or do I need to make this a read/write ioctl?
>
I'd have thought that you'd just copy the number written into msrs->nmsrs via
msrs->nmsrs = num_entries;
like kvm_dev_ioctl_set_msrs() does. Dunno...
next prev parent reply other threads:[~2006-11-17 8:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-16 17:59 [PATCH 0/3] KVM: Save/resume support Avi Kivity
2006-11-16 18:02 ` [PATCH 1/3] KVM: Expose interrupt bitmap Avi Kivity
2006-11-16 18:03 ` [PATCH 2/3] KVM: Add time stamp counter msr and accessors Avi Kivity
2006-11-16 18:04 ` [PATCH 3/3] KVM: Expose MSRs to userspace Avi Kivity
2006-11-16 19:08 ` [kvm-devel] " Arnd Bergmann
2006-11-16 19:17 ` Avi Kivity
2006-11-17 8:06 ` Christoph Hellwig
2006-11-17 1:02 ` Andrew Morton
2006-11-17 7:20 ` Avi Kivity
2006-11-17 8:15 ` Andrew Morton [this message]
2006-11-17 8:17 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061117001510.58f01b3c.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=avi@qumranet.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=uril@qumranet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®