Re: [PATCH -mm] freeze/thaw fs when BLOCK=n

[Pavel Machek <pavel@ucw.cz>]

Hi!

> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> Fix freeze/thaw filesystems with CONFIG_BLOCK disabled:
> kernel/power/process.c:124: warning: implicit declaration of function 'freeze_fil
> esystems'
> kernel/power/process.c:189: warning: implicit declaration of function 'thaw_files
> ystems'
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>

I believe we'll simply want to remove {thaw,freeze}_filesystems. XFS
problem is solved with freezeable workqueues, and
{thaw,freeze}_filesystems has problems if someone is creating dm
snapshots in the meantime.
								Pavel

> ---
>  include/linux/buffer_head.h |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> --- linux-2619-rc5mm2.orig/include/linux/buffer_head.h
> +++ linux-2619-rc5mm2/include/linux/buffer_head.h
> @@ -314,7 +314,8 @@ static inline void invalidate_inode_buff
>  static inline int remove_inode_buffers(struct inode *inode) { return 1; }
>  static inline int sync_mapping_buffers(struct address_space *mapping) { return 0; }
>  static inline void invalidate_bdev(struct block_device *bdev, int destroy_dirty_buffers) {}
> -
> +static inline void freeze_filesystems(void) {}
> +static inline void thaw_filesystems(void) {}
>  
>  #endif /* CONFIG_BLOCK */
>  #endif /* _LINUX_BUFFER_HEAD_H */
> 
> 
> ---

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html