From: Alessandro Zummo <alessandro.zummo@towertech.it>
To: David Brownell <david-b@pacbell.net>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>, akpm@osdl.org
Subject: Re: [patch 2.6.19-rc6] rtc class locking bugfixes
Date: Mon, 20 Nov 2006 00:49:03 +0100 [thread overview]
Message-ID: <20061120004903.00d48a72@inspiron> (raw)
In-Reply-To: <200611162327.37306.david-b@pacbell.net>
On Thu, 16 Nov 2006 23:27:37 -0800
David Brownell <david-b@pacbell.net> wrote:
> I got a lockdep warning when running "rtctest" so I though it'd be good
> to see what was up.
>
> - The warning was for rtc->irq_task_lock, gotten from rtc_update_irq()
> by irq handlerss ... but in a handful of other cases, grabbed without
> blocking IRQs.
>
> - Some callers to rtc_update_irq() were not ensuring IRQs were blocked,
> yet the routine expects that; make sure all callers block IRQs.
>
> It would appear that RTC API tests haven't been part of anyone's kernel
> regression test suite recently, at least not with lockdep running.
>
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Acked-by: Alessandro Zummo <a.zummo@towertech.it>
--
Best regards,
Alessandro Zummo,
Tower Technologies - Turin, Italy
http://www.towertech.it
prev parent reply other threads:[~2006-11-19 23:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-17 7:27 David Brownell
2006-11-19 23:49 ` Alessandro Zummo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061120004903.00d48a72@inspiron \
--to=alessandro.zummo@towertech.it \
--cc=akpm@osdl.org \
--cc=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®