Re: [PATCH] i386 msr: remove unused variable

[Adrian Bunk <bunk@stusta.de>]

On Tue, Nov 21, 2006 at 12:27:22PM -0800, David Rientjes wrote:
> Remove unused variable in msr_write().
> 
> Reported by D Binderman <dcb314@hotmail.com>.
> 
> Cc: H. Peter Anvin <hpa@zytor.com>
> Signed-off-by: David Rientjes <rientjes@cs.washington.edu>
> ---
>  arch/i386/kernel/msr.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/i386/kernel/msr.c b/arch/i386/kernel/msr.c
> index d535cdb..331bd59 100644
> --- a/arch/i386/kernel/msr.c
> +++ b/arch/i386/kernel/msr.c
> @@ -195,7 +195,6 @@ static ssize_t msr_write(struct file *fi
>  {
>  	const u32 __user *tmp = (const u32 __user *)buf;
>  	u32 data[2];
> -	size_t rv;
>  	u32 reg = *ppos;
>  	int cpu = iminor(file->f_dentry->d_inode);
>  	int err;
> @@ -203,7 +202,7 @@ static ssize_t msr_write(struct file *fi
>  	if (count % 8)
>  		return -EINVAL;	/* Invalid chunk size */
>  
> -	for (rv = 0; count; count -= 8) {
> +	for (; count; count -= 8) {
>...

What about changing this to a while() loop?

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed