mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>, dwmw2@infradead.org
Cc: linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
	Akinobu Mita <akinobu.mita@gmail.com>
Subject: [-mm patch] drivers/mtd/nand/rtc_from4.c: use lib/bitrev.c
Date: Wed, 22 Nov 2006 05:38:11 +0100	[thread overview]
Message-ID: <20061122043811.GG5200@stusta.de> (raw)
In-Reply-To: <20061114014125.dd315fff.akpm@osdl.org>

This patch converts drivers/mtd/nand/rtc_from4.c to use the new 
lib/bitrev.c

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 drivers/mtd/nand/Kconfig     |    1 
 drivers/mtd/nand/rtc_from4.c |   44 +----------------------------------
 2 files changed, 3 insertions(+), 42 deletions(-)

--- linux-2.6.19-rc5-mm2/drivers/mtd/nand/Kconfig.old	2006-11-22 05:23:38.000000000 +0100
+++ linux-2.6.19-rc5-mm2/drivers/mtd/nand/Kconfig	2006-11-22 05:23:52.000000000 +0100
@@ -90,6 +90,7 @@
 	depends on MTD_NAND && SH_SOLUTION_ENGINE
 	select REED_SOLOMON
 	select REED_SOLOMON_DEC8
+	select BITREVERSE
 	help
 	  This enables the driver for the Renesas Technology AG-AND
 	  flash interface board (FROM_BOARD4)
--- linux-2.6.19-rc5-mm2/drivers/mtd/nand/rtc_from4.c.old	2006-11-22 05:22:37.000000000 +0100
+++ linux-2.6.19-rc5-mm2/drivers/mtd/nand/rtc_from4.c	2006-11-22 05:24:31.000000000 +0100
@@ -24,6 +24,7 @@
 #include <linux/init.h>
 #include <linux/slab.h>
 #include <linux/rslib.h>
+#include <linux/bitrev.h>
 #include <linux/module.h>
 #include <linux/mtd/compatmac.h>
 #include <linux/mtd/mtd.h>
@@ -152,47 +153,6 @@
 	.oobfree = {{32, 32}}
 };
 
-/* Aargh. I missed the reversed bit order, when I
- * was talking to Renesas about the FPGA.
- *
- * The table is used for bit reordering and inversion
- * of the ecc byte which we get from the FPGA
- */
-static uint8_t revbits[256] = {
-	0x00, 0x80, 0x40, 0xc0, 0x20, 0xa0, 0x60, 0xe0,
-	0x10, 0x90, 0x50, 0xd0, 0x30, 0xb0, 0x70, 0xf0,
-	0x08, 0x88, 0x48, 0xc8, 0x28, 0xa8, 0x68, 0xe8,
-	0x18, 0x98, 0x58, 0xd8, 0x38, 0xb8, 0x78, 0xf8,
-	0x04, 0x84, 0x44, 0xc4, 0x24, 0xa4, 0x64, 0xe4,
-	0x14, 0x94, 0x54, 0xd4, 0x34, 0xb4, 0x74, 0xf4,
-	0x0c, 0x8c, 0x4c, 0xcc, 0x2c, 0xac, 0x6c, 0xec,
-	0x1c, 0x9c, 0x5c, 0xdc, 0x3c, 0xbc, 0x7c, 0xfc,
-	0x02, 0x82, 0x42, 0xc2, 0x22, 0xa2, 0x62, 0xe2,
-	0x12, 0x92, 0x52, 0xd2, 0x32, 0xb2, 0x72, 0xf2,
-	0x0a, 0x8a, 0x4a, 0xca, 0x2a, 0xaa, 0x6a, 0xea,
-	0x1a, 0x9a, 0x5a, 0xda, 0x3a, 0xba, 0x7a, 0xfa,
-	0x06, 0x86, 0x46, 0xc6, 0x26, 0xa6, 0x66, 0xe6,
-	0x16, 0x96, 0x56, 0xd6, 0x36, 0xb6, 0x76, 0xf6,
-	0x0e, 0x8e, 0x4e, 0xce, 0x2e, 0xae, 0x6e, 0xee,
-	0x1e, 0x9e, 0x5e, 0xde, 0x3e, 0xbe, 0x7e, 0xfe,
-	0x01, 0x81, 0x41, 0xc1, 0x21, 0xa1, 0x61, 0xe1,
-	0x11, 0x91, 0x51, 0xd1, 0x31, 0xb1, 0x71, 0xf1,
-	0x09, 0x89, 0x49, 0xc9, 0x29, 0xa9, 0x69, 0xe9,
-	0x19, 0x99, 0x59, 0xd9, 0x39, 0xb9, 0x79, 0xf9,
-	0x05, 0x85, 0x45, 0xc5, 0x25, 0xa5, 0x65, 0xe5,
-	0x15, 0x95, 0x55, 0xd5, 0x35, 0xb5, 0x75, 0xf5,
-	0x0d, 0x8d, 0x4d, 0xcd, 0x2d, 0xad, 0x6d, 0xed,
-	0x1d, 0x9d, 0x5d, 0xdd, 0x3d, 0xbd, 0x7d, 0xfd,
-	0x03, 0x83, 0x43, 0xc3, 0x23, 0xa3, 0x63, 0xe3,
-	0x13, 0x93, 0x53, 0xd3, 0x33, 0xb3, 0x73, 0xf3,
-	0x0b, 0x8b, 0x4b, 0xcb, 0x2b, 0xab, 0x6b, 0xeb,
-	0x1b, 0x9b, 0x5b, 0xdb, 0x3b, 0xbb, 0x7b, 0xfb,
-	0x07, 0x87, 0x47, 0xc7, 0x27, 0xa7, 0x67, 0xe7,
-	0x17, 0x97, 0x57, 0xd7, 0x37, 0xb7, 0x77, 0xf7,
-	0x0f, 0x8f, 0x4f, 0xcf, 0x2f, 0xaf, 0x6f, 0xef,
-	0x1f, 0x9f, 0x5f, 0xdf, 0x3f, 0xbf, 0x7f, 0xff,
-};
-
 #endif
 
 /*
@@ -397,7 +357,7 @@
 	/* Read the syndrom pattern from the FPGA and correct the bitorder */
 	rs_ecc = (volatile unsigned short *)(rtc_from4_fio_base + RTC_FROM4_RS_ECC);
 	for (i = 0; i < 8; i++) {
-		ecc[i] = revbits[(*rs_ecc) & 0xFF];
+		ecc[i] = byte_rev_table[(*rs_ecc) & 0xFF];
 		rs_ecc++;
 	}
 


  parent reply	other threads:[~2006-11-22  4:38 UTC|newest]

Thread overview: 185+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-14  9:41 2.6.19-rc5-mm2 Andrew Morton
2006-11-14 11:11 ` 2.6.19-rc5-mm2 Jiri Slaby
2006-11-14 11:54   ` 2.6.19-rc5-mm2 Jiri Slaby
2006-11-14 11:31 ` 2.6.19-rc5-mm2 Reuben Farrelly
2006-11-14 17:00   ` 2.6.19-rc5-mm2 Gautham R Shenoy
2006-11-14 20:58     ` 2.6.19-rc5-mm2 Mattia Dongili
2006-11-15 10:34       ` 2.6.19-rc5-mm2 Gautham R Shenoy
2006-11-15 10:42         ` 2.6.19-rc5-mm2 Reuben Farrelly
2006-11-14 12:46 ` 2.6.19-rc5-mm2 Mariusz Kozlowski
2006-11-14 13:07   ` 2.6.19-rc5-mm2 Mariusz Kozlowski
2006-11-14 16:41   ` 2.6.19-rc5-mm2 Andrew Morton
2006-11-14 17:09     ` 2.6.19-rc5-mm2 Andrew Morton
2006-11-14 19:23       ` 2.6.19-rc5-mm2 Mariusz Kozlowski
2006-11-14 13:50 ` 2.6.19-rc5-mm2 Eric Dumazet
2006-11-14 18:33 ` [-mm patch] fix the DLM dependencies Adrian Bunk
2006-11-14 22:56   ` [-mm patch] fix the DLM dependencies, part 2 Adrian Bunk
2006-11-15 10:11     ` Patrick Caulfield
2006-11-15 10:23       ` Adrian Bunk
2006-11-14 18:49 ` Boot failure with ext2 and initrds Mel Gorman
2006-11-14 19:08   ` Martin Bligh
2006-11-14 19:11   ` Hugh Dickins
2006-11-14 19:21     ` Martin Bligh
2006-11-14 20:20       ` Hugh Dickins
2006-11-14 20:30         ` Martin Bligh
2006-11-14 19:31     ` Andrew Morton
2006-11-14 21:18       ` Hugh Dickins
2006-11-14 21:19         ` Martin Bligh
2006-11-15 14:17         ` Hugh Dickins
2006-11-15 15:32           ` Martin J. Bligh
2006-11-15 15:56             ` Hugh Dickins
2006-11-16  5:45           ` Andrew Morton
2006-11-16  6:39             ` Andrew Morton
2006-11-16  6:55             ` Mingming Cao
2006-11-16  7:22               ` Andrew Morton
2006-11-16  8:49                 ` Mingming Cao
2006-11-16  9:13                   ` Andrew Morton
2006-11-16  9:37                     ` Alex Tomas
2006-11-16  9:48                       ` Andrew Morton
2006-11-16  9:49                         ` Andrew Morton
2006-11-16 16:26                     ` Hugh Dickins
2006-11-16 20:15                     ` Mingming Cao
2006-11-16 21:27                       ` Andrew Morton
2006-11-20 16:19                         ` Hugh Dickins
2006-11-20 20:54                           ` Hugh Dickins
2006-11-21  1:36                             ` Mingming Cao
2006-11-21  1:47                           ` Mingming Cao
2006-11-21  5:39                             ` Hugh Dickins
2006-11-22  0:43                               ` Mingming Cao
2006-11-28 17:38                                 ` Hugh Dickins
2006-11-28 17:40                                   ` [PATCH 1/6] ext2 balloc: fix _with_rsv freeze Hugh Dickins
2006-11-28 19:26                                     ` Mingming Cao
2006-11-28 20:07                                       ` Hugh Dickins
2006-11-29  0:42                                         ` Mingming Cao
2006-11-29  4:14                                     ` [PATCH 6/12] " Mingming Cao
2006-11-29  4:15                                     ` [PATCH 12/12] ext3 " Mingming Cao
2006-11-28 17:40                                   ` [PATCH 2/6] ext2 balloc: reset windowsz when full Hugh Dickins
2006-11-28 19:36                                     ` Mingming Cao
2006-11-29  4:14                                     ` [PATCH 2/12] ext3 balloc: fix off-by-one against grp_goal Mingming Cao
2006-11-29  4:15                                     ` [PATCH 8/12] ext4 " Mingming Cao
2006-11-28 17:41                                   ` [PATCH 3/6] ext2 balloc: fix off-by-one against rsv_end Hugh Dickins
2006-11-28 19:42                                     ` Mingming Cao
2006-11-28 17:42                                   ` [PATCH 4/6] ext2 balloc: fix off-by-one against grp_goal Hugh Dickins
2006-11-28 23:30                                     ` Mingming Cao
2006-11-29  4:13                                     ` [PATCH 1/12] ext3 balloc: reset windowsz when full Mingming Cao
2006-11-29  5:46                                       ` Hugh Dickins
2006-11-29  4:14                                     ` [PATCH 3/12] ext3 balloc: fix off-by-one against rsv_end Mingming Cao
2006-11-29  4:14                                     ` [PATCH 7/12] ext4 balloc: reset windowsz when full Mingming Cao
2006-11-29  4:15                                     ` [PATCH 9/12] ext4 balloc: fix off-by-one against rsv_end Mingming Cao
2006-11-28 17:43                                   ` [PATCH 5/6] ext2 balloc: say rb_entry not list_entry Hugh Dickins
2006-11-28 23:30                                     ` Mingming Cao
2006-11-29  4:14                                     ` [PATCH 4/12] ext3 " Mingming Cao
2006-11-29  4:15                                     ` [PATCH 10/12] ext4 " Mingming Cao
2006-11-28 17:44                                   ` [PATCH 6/6] ext2 balloc: use io_error label Hugh Dickins
2006-11-28 23:31                                     ` Mingming Cao
2006-11-29  4:14                                     ` [PATCH 5/12] ext3 " Mingming Cao
2006-11-29  4:15                                     ` [PATCH 11/12] ext4 " Mingming Cao
2006-11-28 21:04                                   ` Boot failure with ext2 and initrds Mingming Cao
2006-11-28 22:33                                     ` Andrew Morton
2006-11-28 23:38                                       ` Mingming Cao
2006-11-16 12:34                 ` Russell King
2006-11-25 14:59                   ` Russell King
2006-11-29  7:40                     ` Russell King
2006-11-29  8:30                       ` Andrew Morton
2006-11-29  9:20                         ` Russell King
2006-11-29  9:39                           ` Andrew Morton
2006-11-29 18:16                             ` Russell King
2006-11-14 21:19       ` Mel Gorman
2006-11-15  0:25       ` Andy Whitcroft
2006-11-15  0:58         ` Andrew Morton
2006-11-15 23:54           ` Andy Whitcroft
2006-11-16  9:05       ` Mingming Cao
2006-11-14 20:02 ` 2.6.19-rc5-mm2: no help text for FAULT_INJECTION Adrian Bunk
2006-11-14 21:12   ` [PATCH -mm] CONFIG_FAULT_INJECTION help text Akinobu Mita
2006-11-14 21:15     ` [PATCH -mm] failslab: remove __GFP_HIGHMEM filtering Akinobu Mita
2006-11-14 22:56 ` 2.6.19-rc5-mm2: warnings in MODPOST and later Adrian Bunk
2006-11-14 23:09   ` Andrew Morton
2006-11-15  7:42     ` Arjan van de Ven
2006-11-14 23:13 ` and in www.kernel.org page? Re: 2.6.19-rc5-mm2 Sergio Monteiro Basto
2006-11-15 23:16 ` 2.6.19-rc5-mm2: paravirt X86_PAE=y compile error Adrian Bunk
2006-11-15 23:36   ` Andrew Morton
2006-11-16  1:30     ` Zachary Amsden
2006-11-16  2:27       ` Chris Wright
2006-11-16  7:05         ` Andi Kleen
2006-11-28 23:36     ` Randy Dunlap
2006-11-16 12:16 ` [-mm patch] remove arch/i386/kernel/time_hpet.c:hpet_reenable() Adrian Bunk
2006-11-16 17:17 ` 2.6.19-rc5-mm2 Mattia Dongili
2006-11-16 18:29   ` 2.6.19-rc5-mm2 Stefan Richter
2006-11-16 20:39     ` 2.6.19-rc5-mm2 Mattia Dongili
2006-11-16 22:50       ` 2.6.19-rc5-mm2 Stefan Richter
2006-11-17  7:16         ` 2.6.19-rc5-mm2 Mattia Dongili
2006-11-17 15:02           ` 2.6.19-rc5-mm2 Stefan Richter
2006-11-17 15:24             ` 2.6.19-rc5-mm2 (Oops in class_device_remove_attrs during nodemgr_remove_host) Stefan Richter
2006-11-18  9:47               ` Greg KH
2006-11-18 11:27                 ` Stefan Richter
2006-11-18 17:07                   ` Stefan Richter
2006-11-18 21:45                     ` Stefan Richter
2006-11-18 22:08                       ` Stefan Richter
2006-11-19  8:56                       ` Mattia Dongili
2006-11-19 16:22                       ` ohci1394 oops bisected [was Re: 2.6.19-rc5-mm2 (Oops in class_device_remove_attrs during nodemgr_remove_host)] Mattia Dongili
2006-11-19 17:13                         ` Stefan Richter
2006-11-19 20:33                           ` Andrew Morton
2006-11-19 21:01                             ` Stefan Richter
2006-11-24  8:41                               ` Greg KH
2006-11-24 17:13                                 ` Stefan Richter
2006-11-19 17:14                         ` Gene Heskett
2006-11-19 18:07                           ` Kino segfault (was Re: ohci1394 oops bisected) Stefan Richter
2006-11-19 20:11                             ` Gene Heskett
2006-11-17  1:19 ` [-mm patch] crypto/xcbc.c: make some code static Adrian Bunk
2006-11-17  2:44   ` Herbert Xu
2006-11-17  1:19 ` [-mm patch] make drivers/acpi/bay.c:drive_bays static Adrian Bunk
2006-11-17  1:19 ` [-mm patch] make drivers/base/core.c:setup_parent() static Adrian Bunk
2006-11-17  1:19 ` [-mm patch] make geode_aes_crypt() static Adrian Bunk
2006-11-17 12:42 ` -mm: cx88-blackbird.c: unused code re-added Adrian Bunk
2006-11-17 13:53   ` [v4l-dvb-maintainer] " Michael Krufky
2006-11-17 14:13   ` Mauro Carvalho Chehab
2006-11-17 14:21 ` [-mm patch] drivers/media/video/cafe_ccic.c: make a function static Adrian Bunk
2006-11-17 14:21 ` [-mm patch] remove drivers/pci/search.c:pci_find_device_reverse() Adrian Bunk
2006-11-17 14:32   ` Alan Cox
2006-11-18  0:06     ` [2.6 patch] mark pci_find_device() as __deprecated Adrian Bunk
2006-11-18  1:42       ` Alan
2006-11-19  9:47       ` Arjan van de Ven
2006-11-19  9:52         ` Muli Ben-Yehuda
2006-11-19 10:01           ` Arjan van de Ven
2006-11-19 14:06           ` Adrian Bunk
2006-11-19 15:24             ` Muli Ben-Yehuda
2006-11-19 15:49               ` Adrian Bunk
2006-11-19 16:50               ` Arjan van de Ven
2006-11-19 14:04         ` Adrian Bunk
2006-11-19 14:13           ` Arjan van de Ven
2006-11-19 14:27             ` Adrian Bunk
2006-11-17 19:54   ` [-mm patch] remove drivers/pci/search.c:pci_find_device_reverse() Andrew Morton
2006-11-17 20:33     ` Adrian Bunk
2006-11-17 22:16     ` Alan Cox
2006-11-19  9:44     ` Arjan van de Ven
2006-11-17 17:02 ` [-mm patch] make net/core/skbuff.c:skb_over_panic() static Adrian Bunk
2006-11-21  0:55   ` David Miller
2006-11-21  1:37     ` Andrew Morton
2006-11-21  1:40       ` David Miller
2006-11-21  1:39     ` David Miller
2006-11-17 17:02 ` [-mm patch] security/slim/slm_main.c: make 2 functions static Adrian Bunk
2006-11-17 23:58 ` [-mm patch] make sound/pci/hda/patch_sigmatel.c:stac92xx_dmic_labels[] static Adrian Bunk
2006-11-20 16:44   ` [Alsa-devel] " Takashi Iwai
2006-11-17 23:58 ` [-mm patch] make mm/thrash.c:global_faults static Adrian Bunk
2006-11-17 23:59 ` [RFC: -mm patch] remove kernel/timer.c:wall_jiffies Adrian Bunk
2006-11-18  7:00   ` Ingo Molnar
2006-11-17 23:59 ` [RFC: -mm patch] make kernel/timer.c:__next_timer_interrupt() static Adrian Bunk
2006-11-18  6:58   ` Ingo Molnar
2006-11-20  2:23 ` [-mm patch] drivers/scsi/scsi_scan.c: make 2 functions static Adrian Bunk
2006-11-20  2:34   ` Matthew Wilcox
2006-11-20  2:24 ` [-mm patch] fs/dlm/lowcomms-tcp.c: remove 2 functions Adrian Bunk
2006-11-20  2:24 ` [-mm patch] make ext2_get_blocks() static Adrian Bunk
2006-11-20  2:24 ` [-mm patch] fs/reiser4/: possible cleanups Adrian Bunk
2006-11-21 18:37 ` -mm: please drop reiser4-export-handle_ra_miss.patch Adrian Bunk
2006-11-21 19:42 ` [-mm patch] unexport {,__}remove_from_page_cache Adrian Bunk
2006-11-22  3:23 ` 2.6.19-rc5-mm2: suspend related BLOCK=n compile error Adrian Bunk
2006-11-22  3:34   ` Randy Dunlap
2006-11-22 11:20     ` Rafael J. Wysocki
2006-11-22  4:17 ` [-mm patch] CACHEFILES must depend on PROC_FS Adrian Bunk
2006-11-22  4:35   ` Randy Dunlap
2006-11-22  4:17 ` [-mm patch] fs/fscache/main.c: cleanups Adrian Bunk
2006-11-22  4:38 ` Adrian Bunk [this message]
2006-11-28 22:19   ` [-mm patch] drivers/mtd/nand/rtc_from4.c: use lib/bitrev.c David Woodhouse
2006-11-28 22:49     ` Andrew Morton
2006-11-28 22:52       ` David Woodhouse
2006-11-29  0:09         ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061122043811.GG5200@stusta.de \
    --to=bunk@stusta.de \
    --cc=akinobu.mita@gmail.com \
    --cc=akpm@osdl.org \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome