From: Muli Ben-Yehuda <muli@il.ibm.com>
To: d binderman <dcb314@hotmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH x86-64] Calgary: remove unused vars
Date: Wed, 22 Nov 2006 14:09:27 +0200 [thread overview]
Message-ID: <20061122120927.GI4118@rhun.haifa.ibm.com> (raw)
In-Reply-To: <BAY107-F16375715795A91CEA1E2D99CE30@phx.gbl>
On Wed, Nov 22, 2006 at 11:45:24AM +0000, d binderman wrote:
>
> Hello there,
>
> I just tried to compile Linux kernel 2.6.18.3 with the Intel C
> C compiler.
>
> The compiler said
>
> arch/x86_64/kernel/pci-calgary.c(600): remark #593: variable "bbar" was set
> but never used
> arch/x86_64/kernel/pci-calgary.c(601): remark #593: variable "busnum" was
> set but never used
>
> The source code is
>
> void __iomem *bbar;
> unsigned char busnum;
>
> I have checked the source code and I agree with the compiler.
> Suggest delete local variables.
Thanks, I agree. Andi, please apply.
[PATCH x86-64] Calgary: remove unused vars
Spotted by d binderman <dcb314@hotmail.com>.
Signed-off-by: Muli Ben-Yehuda <muli@il.ibm.com>
diff -r aed4939c234b -r acb0eb3ee9c3 arch/x86_64/kernel/pci-calgary.c
--- a/arch/x86_64/kernel/pci-calgary.c Mon Nov 20 22:44:19 2006 +0200
+++ b/arch/x86_64/kernel/pci-calgary.c Wed Nov 22 14:08:19 2006 +0200
@@ -653,13 +653,8 @@ static void __init calgary_reserve_regio
static void __init calgary_reserve_regions(struct pci_dev *dev)
{
unsigned int npages;
- void __iomem *bbar;
- unsigned char busnum;
u64 start;
struct iommu_table *tbl = dev->sysdata;
-
- bbar = tbl->bbar;
- busnum = dev->bus->number;
/* reserve bad_dma_address in case it's a legal address */
iommu_range_reserve(tbl, bad_dma_address, 1);
prev parent reply other threads:[~2006-11-22 12:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-22 11:45 arch/x86_64/kernel/pci-calgary.c(600): remark #593: variable "bbar" was set but d binderman
2006-11-22 12:09 ` Muli Ben-Yehuda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061122120927.GI4118@rhun.haifa.ibm.com \
--to=muli@il.ibm.com \
--cc=dcb314@hotmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®