From: Andrew Morton <akpm@osdl.org>
To: "Conke Hu" <conke.hu@amd.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Add IDE mode support for SB600 SATA
Date: Wed, 22 Nov 2006 18:26:10 -0800 [thread overview]
Message-ID: <20061122182610.4d9f3d98.akpm@osdl.org> (raw)
In-Reply-To: <FFECF24D2A7F6D418B9511AF6F3586020108CD36@shacnexch2.atitech.com>
On Thu, 23 Nov 2006 06:23:50 +0800
"Conke Hu" <conke.hu@amd.com> wrote:
> ATI SB600 SATA controller supports 4 modes: Legacy IDE, Native IDE, AHCI and RAID. Legacy/Native IDE mode is designed for compatibility with some old OS without AHCI driver but looses SATAII/AHCI features such as NCQ. This patch provides users with two options when the SB600 SATA is set as IDE mode by BIOS:
> 1. Setting the controller back to AHCI mode and using ahci as its driver.
> 2. Using the controller as a normal IDE.
> What's more, without this patch, ahci driver always tries to claim all 4 modes of SB600 SATA, but fails in legacy IDE mode.
>
> Signed-off-by: conke.hu@amd.com
> -------
> diff -Nur linux-2.6.19-rc6-git4.orig/drivers/ata/ahci.c linux-2.6.19-rc6-git4/drivers/ata/ahci.c
> --- linux-2.6.19-rc6-git4.orig/drivers/ata/ahci.c 2006-11-23 13:36:52.000000000 +0800
> +++ linux-2.6.19-rc6-git4/drivers/ata/ahci.c 2006-11-23 13:50:13.000000000 +0800
> @@ -323,7 +323,14 @@
> { PCI_VDEVICE(JMICRON, 0x2366), board_ahci }, /* JMicron JMB366 */
>
> /* ATI */
> +#ifdef CONFIG_SB600_AHCI_IDE
> { PCI_VDEVICE(ATI, 0x4380), board_ahci }, /* ATI SB600 non-raid */
> +#else
> + { PCI_VENDOR_ID_ATI, 0x4380, PCI_ANY_ID, PCI_ANY_ID, PCI_CLASS_STORAGE_RAID<<8, 0xffff00,
> + board_ahci },
> + { PCI_VENDOR_ID_ATI, 0x4380, PCI_ANY_ID, PCI_ANY_ID, 0x010600, 0xffff00,
> + board_ahci },
> +#endif
> { PCI_VDEVICE(ATI, 0x4381), board_ahci }, /* ATI SB600 raid */
I doubt if it's appropriate to do all this via ifdefs. Users don't compile
their kernels - others compile them for the users. We need the one kernel
binary to support both modes. Possible?
next prev parent reply other threads:[~2006-11-23 2:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-22 22:23 Conke Hu
2006-11-23 2:26 ` Andrew Morton [this message]
2006-11-23 11:13 ` Alan
2006-11-23 2:31 ` Andrew Morton
2006-11-23 4:04 Conke Hu
2006-11-23 4:20 Conke Hu
2006-11-23 8:05 ` Arjan van de Ven
2006-11-23 11:22 ` Alan
2006-11-23 13:12 ` Arjan van de Ven
2006-11-23 11:21 ` Alan
2006-11-24 6:01 ` Tejun Heo
2006-11-24 7:05 ` Tejun Heo
2006-11-24 11:13 ` Alan
2006-11-25 1:43 ` Tejun Heo
2006-11-23 4:24 Conke Hu
2006-11-23 9:50 Conke Hu
2006-11-23 10:16 Conke Hu
2006-11-23 16:35 Luugi Marsan
2006-11-23 16:45 ` Alan
2006-11-24 5:21 Conke Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061122182610.4d9f3d98.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=conke.hu@amd.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®