From: Andi Kleen <ak@suse.de>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: lkml <linux-kernel@vger.kernel.org>, akpm <akpm@osdl.org>
Subject: Re: [PATCH] X86_genericarch needs SMP?
Date: Wed, 22 Nov 2006 18:50:11 +0100 [thread overview]
Message-ID: <200611221850.11965.ak@suse.de> (raw)
In-Reply-To: <20061122094842.75f3d35b.randy.dunlap@oracle.com>
On Wednesday 22 November 2006 18:48, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> With
> CONFIG_SMP=n, CONFIG_X86_GENERICARCH=y
> (and CONFIG_X86_SUMMIT=n), kernel build gets:
>
> arch/i386/mach-generic/built-in.o: In function `apicid_to_node':
> summit.c:(.text+0x54): undefined reference to `apicid_2_node'
>
> so should X86_GENERICARCH depend on SMP?
> or should there be more ifdefs in the source files?
I already fixed that here in a different way, but the patch didn't make
it to Linus yet.
-Andi
prev parent reply other threads:[~2006-11-22 17:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-22 17:48 Randy Dunlap
2006-11-22 17:50 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200611221850.11965.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®