From: Alan <alan@lxorguk.ukuu.org.uk>
To: Juergen Beisert <juergen127@kreuzholzen.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 001/001] i386/pci: fix nibble permutation and add Cyrix 5530 IRQ router
Date: Fri, 24 Nov 2006 11:41:56 +0000 [thread overview]
Message-ID: <20061124114156.1b02cf2e@localhost.localdomain> (raw)
In-Reply-To: <200611241144.06267.juergen127@kreuzholzen.de>
On Fri, 24 Nov 2006 11:44:05 +0100
> Cyrix 5520 and Cyrix 5530 do interrupt routing in the same way. But the
> (pirq-1)^1 expression to set a route always sets the wrong nibble, so
> INTA/INTB and INTC/INTD are permuted and do not work as expected.
>
> Signed-off-by: Juergen Beisert <juergen.beisert@weihenstephan.org>
NAK
This will then break other boards. As far as I can tell there is no
"correct" answer here for 5530 based hardware. The existing setup makes
most random CS5520/30 based PC systems like the Palmax laptops work if the
irq router is used, your change will break them
Given the choice between LinuxBIOS and the rest of the world then the
rest of the world needs to win. The 5530 is absent from the IRQ routing
table because it varied by system what the right answer was.
Alan
next prev parent reply other threads:[~2006-11-24 11:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-24 10:44 Juergen Beisert
2006-11-24 11:41 ` Alan [this message]
2006-11-24 13:09 ` Juergen Beisert
2006-11-24 13:35 ` Alan
2006-11-24 13:46 ` Juergen Beisert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061124114156.1b02cf2e@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=juergen127@kreuzholzen.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®