From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967223AbWKYVkz (ORCPT ); Sat, 25 Nov 2006 16:40:55 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S967224AbWKYVky (ORCPT ); Sat, 25 Nov 2006 16:40:54 -0500 Received: from out2.smtp.messagingengine.com ([66.111.4.26]:63440 "EHLO out2.smtp.messagingengine.com") by vger.kernel.org with ESMTP id S967223AbWKYVkx (ORCPT ); Sat, 25 Nov 2006 16:40:53 -0500 X-Sasl-enc: OEX9kjeTdn8JKvAmcaNLxleK1IGXMQnS5sI7ZCd7kj8p 1164490854 Date: Sat, 25 Nov 2006 19:40:45 -0200 From: Henrique de Moraes Holschuh To: Adrian Bunk Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, ibm-acpi@hmh.eng.br, len.brown@intel.com, linux-acpi@vger.kernel.org Subject: Re: [2.6 patch] proper prototype for drivers/base/init.c:driver_init() Message-ID: <20061125214045.GJ1537@khazad-dum.debian.net> References: <20061125191645.GI3702@stusta.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20061125191645.GI3702@stusta.de> X-GPG-Fingerprint: 1024D/1CDB0FE3 5422 5C61 F6B7 06FB 7E04 3738 EE25 DE3F 1CDB 0FE3 User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 25 Nov 2006, Adrian Bunk wrote: > It also removes a static function of the same name in > drivers/acpi/ibm_acpi.c to ibm_acpi_driver_init() to fix the namespace > collision. I might as well fix the entire ibm-acpi driver so that it doesn't have any more issues like this in the future. I will prepare a patch. I never liked namespace-pollution-prone symbols, anyway. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh