From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: tori@unhappy.mine.nu, jgarzik@pobox.com,
linux-kernel@vger.kernel.org, akpm@osdl.org,
sebastien.hinderer@loria.fr
Subject: Re: Tulip dmfe carrier detection
Date: Sat, 25 Nov 2006 23:21:23 +0100 [thread overview]
Message-ID: <20061125222123.GA9167@implementation.residence.ens-lyon.fr> (raw)
In-Reply-To: <20061110144919.GI3411@implementation.labri.fr>
Hi,
Samuel Thibault, le Fri 10 Nov 2006 15:49:19 +0100, a écrit :
> The dmfe module lacks netif stuff for carrier detection, while the board
> does report carrier status. Here is a patch.
Just an additional fixup: the default state should be carrier off.
This fixes boot carrier detection.
Samuel
--- drivers/net/tulip/dmfe-orig.c 2006-10-01 16:09:49.000000000 +0200
+++ drivers/net/tulip/dmfe.c 2006-11-25 21:23:52.000000000 +0100
@@ -426,6 +426,7 @@
dev->poll_controller = &poll_dmfe;
#endif
dev->ethtool_ops = &netdev_ethtool_ops;
+ netif_carrier_off(db->dev);
spin_lock_init(&db->lock);
pci_read_config_dword(pdev, 0x50, &pci_pmr);
prev parent reply other threads:[~2006-11-25 22:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-10 14:49 Samuel Thibault
2006-11-25 22:21 ` Samuel Thibault [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061125222123.GA9167@implementation.residence.ens-lyon.fr \
--to=samuel.thibault@ens-lyon.org \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sebastien.hinderer@loria.fr \
--cc=tori@unhappy.mine.nu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®