mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, Jeff Garzik <jgarzik@pobox.com>
Subject: [patch] IRQ handler type mismatch for IRQ 14
Date: Mon, 27 Nov 2006 12:06:07 +0100	[thread overview]
Message-ID: <20061127110607.GA22050@elte.hu> (raw)

From: Ingo Molnar <mingo@elte.hu>
Subject: [patch] IRQ handler type mismatch for IRQ 14

got this with all SATA/PATA drivers enabled:

 Calling initcall 0xc05aceed: legacy_init+0x0/0x5b3()
 ata5: PATA max PIO4 cmd 0x170 ctl 0x376 bmdma 0x0 irq 14
 IRQ handler type mismatch for IRQ 14
 current handler: ide0
  [<c010501e>] dump_trace+0x64/0x1cc
  [<c010519f>] show_trace_log_lvl+0x19/0x2e
  [<c0105511>] show_trace+0x12/0x14
  [<c010552a>] dump_stack+0x17/0x19
  [<c016078f>] setup_irq+0x1c2/0x1dc
  [<c0160830>] request_irq+0x87/0xa7
  [<c02cc7c6>] ata_device_add+0x296/0x4dc
  [<c05ad3e0>] legacy_init+0x4f3/0x5b3
  [<c01004f9>] init+0x135/0x3c0
  [<c0104d67>] kernel_thread_helper+0x7/0x10

the patch below solves it, although i suspect the irq_flags field could 
be eliminated altogether now - all drivers must be prepared to handle 
shared interrupts.

Signed-off-by: Ingo Molnar <mingo@elte.hu>

Index: linux/drivers/ata/libata-core.c
===================================================================
--- linux.orig/drivers/ata/libata-core.c
+++ linux/drivers/ata/libata-core.c
@@ -5526,8 +5526,8 @@ int ata_device_add(const struct ata_prob
 	}
 
 	/* obtain irq, that may be shared between channels */
-	rc = request_irq(ent->irq, ent->port_ops->irq_handler, ent->irq_flags,
-			 DRV_NAME, host);
+	rc = request_irq(ent->irq, ent->port_ops->irq_handler,
+			 ent->irq_flags | SA_SHIRQ, DRV_NAME, host);
 	if (rc) {
 		dev_printk(KERN_ERR, dev, "irq %lu request failed: %d\n",
 			   ent->irq, rc);
@@ -5540,8 +5540,8 @@ int ata_device_add(const struct ata_prob
 		   so trap it now */
 		BUG_ON(ent->irq == ent->irq2);
 
-		rc = request_irq(ent->irq2, ent->port_ops->irq_handler, ent->irq_flags,
-			 DRV_NAME, host);
+		rc = request_irq(ent->irq2, ent->port_ops->irq_handler,
+				 ent->irq_flags | SA_SHIRQ, DRV_NAME, host);
 		if (rc) {
 			dev_printk(KERN_ERR, dev, "irq %lu request failed: %d\n",
 				   ent->irq2, rc);

                 reply	other threads:[~2006-11-28  8:43 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061127110607.GA22050@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@osdl.org \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®