From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Russell King <rmk+lkml@arm.linux.org.uk>
Cc: Greg K-H <greg@kroah.com>, Andrew Morton <akpm@osdl.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [Patch 3/7] driver core fixes: device_register() retval check in platform.c
Date: Mon, 27 Nov 2006 12:48:01 +0100 [thread overview]
Message-ID: <20061127124801.0248e3f6@gondolin.boeblingen.de.ibm.com> (raw)
In-Reply-To: <20061127112447.GA28761@flint.arm.linux.org.uk>
On Mon, 27 Nov 2006 11:24:47 +0000,
Russell King <rmk+lkml@arm.linux.org.uk> wrote:
> I still say this is absolutely crazy. If a bus does not get registered,
> what happens to all the devices and drivers which are registered against
> that bus?
This is a generic problem. Does any driver check if the bus it is
registering against is really present? Or should the driver core check
whether a bus is registered when someone tries to register a
device/driver?
> I suspect that if this bus_register doesn't work, you'll see an oops
> sooner or later. So it might as well be a BUG_ON here.
What we need to do here is to make sure we get to know that something
went really wrong here. If a BUG_ON is considered preferrable to oopses
on platform device registering, I can roll a patch.
--
Cornelia Huck
Linux for zSeries Developer
Tel.: +49-7031-16-4837, Mail: cornelia.huck@de.ibm.com
next prev parent reply other threads:[~2006-11-27 11:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-27 9:35 Cornelia Huck
2006-11-27 11:24 ` Russell King
2006-11-27 11:48 ` Cornelia Huck [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-10-27 11:36 Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061127124801.0248e3f6@gondolin.boeblingen.de.ibm.com \
--to=cornelia.huck@de.ibm.com \
--cc=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®