From: Andrew Morton <akpm@osdl.org>
To: David Howells <dhowells@redhat.com>
Cc: Adrian Bunk <bunk@stusta.de>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] kill net/rxrpc/rxrpc_syms.c
Date: Mon, 27 Nov 2006 19:33:13 -0800 [thread overview]
Message-ID: <20061127193313.d59f61f0.akpm@osdl.org> (raw)
In-Reply-To: <30354.1164626485@redhat.com>
On Mon, 27 Nov 2006 11:21:25 +0000
David Howells <dhowells@redhat.com> wrote:
> Adrian Bunk <bunk@stusta.de> wrote:
>
> > This patch moves the EXPORT_SYMBOL's from net/rxrpc/rxrpc_syms.c to the
> > files with the actual functions.
>
> You can if you like. Can you slap a blank line before each EXPORT_SYMBOL()
> though please?
We have a mixture of both styles and given that they waste space in return
for no added value, people have been gradually removing these blank lines
in many places. Please don't add more.
next prev parent reply other threads:[~2006-11-28 3:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-26 4:04 Adrian Bunk
2006-11-27 11:21 ` David Howells
2006-11-28 1:28 ` Adrian Bunk
2006-11-28 3:33 ` Andrew Morton [this message]
2006-11-28 3:54 ` Arnaldo Carvalho de Melo
2006-11-28 11:18 ` David Howells
2007-02-20 0:06 Adrian Bunk
2007-02-20 10:59 ` David Howells
2007-02-20 11:29 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061127193313.d59f61f0.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®