mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: lkml <linux-kernel@vger.kernel.org>
Cc: akpm <akpm@osdl.org>, perex@suse.cz
Subject: [PATCH -mm] ALSA: add struct forward declaration
Date: Tue, 28 Nov 2006 22:06:33 -0800	[thread overview]
Message-ID: <20061128220633.850e5051.randy.dunlap@oracle.com> (raw)

From: Randy Dunlap <randy.dunlap@oracle.com>

I see about 10 sets of these in a random config.

  CC      drivers/media/video/saa7134/saa7134-cards.o
In file included from drivers/media/video/saa7134/saa7134.h:43,
                 from drivers/media/video/saa7134/saa7134-cards.c:27:
include/sound/pcm.h:59: warning: 'struct snd_pcm_substream' declared inside parameter list
include/sound/pcm.h:59: warning: its scope is only this definition or declaration, which is probably not what you want
include/sound/pcm.h:60: warning: 'struct snd_pcm_substream' declared inside parameter list
include/sound/pcm.h:62: warning: 'struct snd_pcm_substream' declared inside parameter list
include/sound/pcm.h:64: warning: 'struct snd_pcm_substream' declared inside parameter list
include/sound/pcm.h:65: warning: 'struct snd_pcm_substream' declared inside parameter list
include/sound/pcm.h:66: warning: 'struct snd_pcm_substream' declared inside parameter list
include/sound/pcm.h:67: warning: 'struct snd_pcm_substream' declared inside parameter list
include/sound/pcm.h:68: warning: 'struct snd_pcm_substream' declared inside parameter list
include/sound/pcm.h:71: warning: 'struct snd_pcm_substream' declared inside parameter list
include/sound/pcm.h:73: warning: 'struct snd_pcm_substream' declared inside parameter list
include/sound/pcm.h:75: warning: 'struct snd_pcm_substream' declared inside parameter list
include/sound/pcm.h:76: warning: 'struct snd_pcm_substream' declared inside parameter list
include/sound/pcm.h:77: warning: 'struct snd_pcm_substream' declared inside parameter list

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 include/sound/pcm.h |    2 ++
 1 file changed, 2 insertions(+)

--- linux-2.6.19-rc6-mm2.orig/include/sound/pcm.h
+++ linux-2.6.19-rc6-mm2/include/sound/pcm.h
@@ -55,6 +55,8 @@ struct snd_pcm_hardware {
 	size_t fifo_size;		/* fifo size in bytes */
 };
 
+struct snd_pcm_substream;
+
 struct snd_pcm_ops {
 	int (*open)(struct snd_pcm_substream *substream);
 	int (*close)(struct snd_pcm_substream *substream);


---

                 reply	other threads:[~2006-11-29  6:06 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061128220633.850e5051.randy.dunlap@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®