From: Andrew Morton <akpm@osdl.org>
To: Mauricio Lin <mauricio.lin@indt.org.br>
Cc: linux-kernel@vger.kernel.org, greg@kroah.com
Subject: Re: [PATCH 2.6.19] kobject: kobject_uevent() returns manageable value
Date: Thu, 30 Nov 2006 23:08:12 -0800 [thread overview]
Message-ID: <20061130230812.dad6b0b2.akpm@osdl.org> (raw)
In-Reply-To: <456F4607.3000300@indt.org.br>
On Thu, 30 Nov 2006 16:58:47 -0400
Mauricio Lin <mauricio.lin@indt.org.br> wrote:
> Since kobject_uevent() function does not return an integer value to
> indicate if its operation was completed with success or not, it is
> worth changing it in order to report a proper status (success or
> error) instead of returning void.
>
> Keep kobject_uevent() returning the status as integer provide a easier
> way for detecting possible failure in the function. Using void
> returning style may take people to waste more time to figure out if
> the "send to" or "receive from" an event is a bug in the kernel or
> user space. Furthermore, the current way to detect where the error is
> taking place in the kobject_uevent() requires additional inclusion of
> printk() in each "if" condition that can lead to failure.
Admirable idea, but we have large changes pending against that code
and none of this patch applies.
A patch against Greg's driver tree, or against latest -mm would suit, thanks.
next prev parent reply other threads:[~2006-12-01 7:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-30 20:58 Mauricio Lin
2006-12-01 7:08 ` Andrew Morton [this message]
2006-12-01 15:46 ` Mauricio Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061130230812.dad6b0b2.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mauricio.lin@indt.org.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome