From: Grant Grundler <grundler@parisc-linux.org>
To: Adrian Bunk <bunk@stusta.de>
Cc: Grant Grundler <grundler@parisc-linux.org>,
Andrew Morton <akpm@osdl.org>,
matthew@wil.cx, kyle@parisc-linux.org,
parisc-linux@parisc-linux.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] parisc: "extern inline" -> "static inline" (fwd)
Date: Fri, 1 Dec 2006 10:36:47 -0700 [thread overview]
Message-ID: <20061201173647.GB10549@colo.lackof.org> (raw)
In-Reply-To: <20061201165427.GD11084@stusta.de>
On Fri, Dec 01, 2006 at 05:54:27PM +0100, Adrian Bunk wrote:
> If you read John David Anglin's email, you'll note that if you take the
> address you need this function provided somewhere.
Let me turn that around.
Which of the "extern inline" functions are we taking the address?
The parisc kernel wouldn't (shouldn't) link if that were true.
> Which of the functions my patch changes also have a global function
> provided within the kernel?
>
> If none, "extern inline" didn't make any sense.
I expect none.
...
> Currently, "inline" is defined to be always_inline, and
> __always_inline is for cases that produce non-compiling or non-working
> (opposed to only suboptimal) code.
Ok. Sounds like "extern inline" is the same as __always_inline.
Has gcc community confirmed "gcc -Wmissing-prototypes" behavior
is really correct with respect to "extern inline"?
If so, I'm ok with changing "extern inline" to __always_inline.
thanks,
grant
next prev parent reply other threads:[~2006-12-01 17:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-01 11:48 Adrian Bunk
2006-12-01 16:43 ` Grant Grundler
2006-12-01 16:54 ` Adrian Bunk
2006-12-01 17:36 ` Grant Grundler [this message]
2006-12-01 17:38 ` [parisc-linux] Re: [2.6 patch] parisc: "extern inline" -> "static John David Anglin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061201173647.GB10549@colo.lackof.org \
--to=grundler@parisc-linux.org \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=kyle@parisc-linux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=parisc-linux@parisc-linux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®