From: Alan <alan@lxorguk.ukuu.org.uk>
To: Jesper Juhl <jesper.juhl@gmail.com>
Cc: linux-kernel@vger.kernel.org, Martin Mares <mj@ucw.cz>
Subject: Re: [PATCH] Be a bit defensive in quirk_nvidia_ck804() so we don't risk dereferencing a NULL pdev.
Date: Fri, 1 Dec 2006 23:55:41 +0000 [thread overview]
Message-ID: <20061201235541.7ff63a13@localhost.localdomain> (raw)
In-Reply-To: <200612020021.56250.jesper.juhl@gmail.com>
On Sat, 2 Dec 2006 00:21:56 +0100
Jesper Juhl <jesper.juhl@gmail.com> wrote:
> pci_get_slot() may return NULL if nothing was found.
> quirk_nvidia_ck804() does not check the value returned from pci_get_slot(),
> so it may end up causing a NULL pointer deref.
>
>
> Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
I don't think its a physically possible case but it does no harm and
it'll kill boot if it happens
Acked-by: Alan Cox <alan@redhat.com>
next prev parent reply other threads:[~2006-12-01 23:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-01 23:21 Jesper Juhl
2006-12-01 23:55 ` Alan [this message]
2006-12-02 0:59 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061201235541.7ff63a13@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=jesper.juhl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mj@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome