mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan <alan@lxorguk.ukuu.org.uk>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: PCI: switch pci_{enable,disable}_device() to be nestable
Date: Sat, 2 Dec 2006 11:27:29 +0000	[thread overview]
Message-ID: <20061202112729.4fb43dbf@localhost.localdomain> (raw)
In-Reply-To: <200612020059.kB20xwaL004140@hera.kernel.org>

>     However, because the order at which those drivers load cannot be known
>     ahead of time, the sequence in which the calls to pci_enable_device()
>     and pci_disable_device() cannot be predicted. Thus:
>     
>     1. driverA     starts     pci_enable_device()
>     2. driverB     starts     pci_enable_device()
>     3. driverA     shutdown   pci_disable_device()
>     4. driverB     shutdown   pci_disable_device()
>     
>     between steps 3 and 4, driver B would loose access to it's device,
>     even if it didn't intend to.

This is insufficient for some cases. Someone needs to set the enabled
value to one for unclaimed devices which are found to be enabled at boot
time (IO/MEM set) otherwise the stacking will fail on things like a
CS5520 where the firmware has set it enabled and if you disable it your
system dies on the spot.

Otherwise this looks most welcome.

Alan

           reply	other threads:[~2006-12-02 11:20 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <200612020059.kB20xwaL004140@hera.kernel.org>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061202112729.4fb43dbf@localhost.localdomain \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®