From: Alan <alan@lxorguk.ukuu.org.uk>
To: "Robert P. J. Day" <rpjday@mindspring.com>
Cc: Linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fs: Convert kmalloc()+memset() combo to kzalloc().
Date: Sun, 3 Dec 2006 16:41:09 +0000 [thread overview]
Message-ID: <20061203164109.4c260592@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.64.0612031120110.4371@localhost.localdomain>
> if (!p) {
> - p = kmalloc(sizeof(*p), GFP_KERNEL);
> + p = kzalloc(sizeof(*p), GFP_KERNEL);
> if (!p)
> return -ENOMEM;
> file->private_data = p;
> }
> - memset(p, 0, sizeof(*p));
> mutex_init(&p->lock);
> p->op = op;
NAK
If p was already set (ie private data existed) the old code zeroed it,
your code does not, but only zeroes the new stuff.
Alan
next prev parent reply other threads:[~2006-12-03 16:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-03 16:21 Robert P. J. Day
2006-12-03 16:38 ` Jiri Slaby
2006-12-03 16:41 ` Alan [this message]
2006-12-03 16:40 ` Robert P. J. Day
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061203164109.4c260592@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=rpjday@mindspring.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®